-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: FT.PROFILE
#2473
Merged
Merged
Java: FT.PROFILE
#2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
October 17, 2024 21:01 — with
GitHub Actions
Inactive
13 tasks
Yury-Fridlyand
force-pushed
the
java/yuryf-ft-profile-valkey-424
branch
from
October 17, 2024 23:18
6641d4d
to
6b23e6b
Compare
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
October 17, 2024 23:20 — with
GitHub Actions
Inactive
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 17, 2024 23:20 — with
GitHub Actions
Error
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
force-pushed
the
java/yuryf-ft-profile-valkey-424
branch
from
October 18, 2024 19:13
94ae1d3
to
f1e346e
Compare
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
October 18, 2024 19:13 — with
GitHub Actions
Inactive
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 18, 2024 19:13 — with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 18, 2024 19:13 — with
GitHub Actions
Error
…t-profile-valkey-424 Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 18, 2024 23:09 — with
GitHub Actions
Failure
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 18, 2024 23:09 — with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 18, 2024 23:09 — with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 19, 2024 00:59 — with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 19, 2024 00:59 — with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 19, 2024 00:59 — with
GitHub Actions
Error
…t-profile-valkey-424 Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
October 21, 2024 23:15 — with
GitHub Actions
Inactive
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 21, 2024 23:15 — with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 21, 2024 23:15 — with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 21, 2024 23:53 — with
GitHub Actions
Error
java/client/src/main/java/glide/api/models/commands/FT/FTProfileOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/FT/FTProfileOptions.java
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/FT/FTProfileOptions.java
Show resolved
Hide resolved
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
October 24, 2024 16:41 — with
GitHub Actions
Inactive
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 24, 2024 16:41 — with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 24, 2024 16:41 — with
GitHub Actions
Error
acarbonetto
reviewed
Oct 24, 2024
@@ -1472,6 +1511,14 @@ pub(crate) fn expected_type_for_cmd(cmd: &Cmd) -> Option<ExpectedReturnType> { | |||
}), | |||
b"FT.AGGREGATE" => Some(ExpectedReturnType::FTAggregateReturnType), | |||
b"FT.SEARCH" => Some(ExpectedReturnType::FTSearchReturnType), | |||
// TODO replace with tuple | |||
b"FT.PROFILE" => Some(ExpectedReturnType::FTProfileReturnType( | |||
if cmd.arg_idx(2).is_some_and(|a| a == b"SEARCH") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting solution - good re-use of code
java/client/src/main/java/glide/api/models/commands/FT/FTProfileOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 25, 2024 17:59 — with
GitHub Actions
Failure
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 25, 2024 17:59 — with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 25, 2024 17:59 — with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 25, 2024 18:12 — with
GitHub Actions
Failure
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
October 25, 2024 18:12 — with
GitHub Actions
Failure
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
October 25, 2024 18:12 — with
GitHub Actions
Inactive
public class FTProfileOptions { | ||
private final QueryType queryType; | ||
private final boolean limited; | ||
private final GlideString[] commandLine; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. This avoids the confusion between query and commandLine.
prateek-kumar-improving
approved these changes
Oct 28, 2024
acarbonetto
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#2428
Checklist
Before submitting the PR make sure the following are checked: