redis-rs code cleanup: keep a single async runtime: tokio
#2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed dead code for `async-std` - Fixed `redis-rs` tests so they could be run with a simple `cargo test` command - Changed the default features to include: "tokio-comp", "tokio-rustls-comp", "connection-manager", "cluster", "cluster-async" - Fixed a flaky `glide-core` test Signed-off-by: Eran Ifrah <eifrah@amazon.com>
9f29e37 to
1368f66
Compare
redis-rs code cleanup: keep a single Runtime: tokioredis-rs code cleanup: keep a single async runtime: tokio
| format!("sending {} messages", config.number_of_requests_sent), | ||
| ); | ||
|
|
||
| tokio::time::sleep(tokio::time::Duration::from_millis(100)).await; |
There was a problem hiding this comment.
Why do we need this tokio::time::sleep call?
avifenesh
pushed a commit
to avifenesh/valkey-glide
that referenced
this pull request
Oct 21, 2024
…-io#2459) Keep a single Runtime: `tokio` - Removed dead code for `async-std` - Fixed `redis-rs` tests so they could be run with a simple `cargo test` command - Changed the default features to include: "tokio-comp", "tokio-rustls-comp", "connection-manager", "cluster", "cluster-async" - Fixed a flaky `glide-core` test Signed-off-by: Eran Ifrah <eifrah@amazon.com>
avifenesh
pushed a commit
to avifenesh/valkey-glide
that referenced
this pull request
Oct 21, 2024
…-io#2459) Keep a single Runtime: `tokio` - Removed dead code for `async-std` - Fixed `redis-rs` tests so they could be run with a simple `cargo test` command - Changed the default features to include: "tokio-comp", "tokio-rustls-comp", "connection-manager", "cluster", "cluster-async" - Fixed a flaky `glide-core` test Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Muhammad-awawdi-amazon
pushed a commit
to Muhammad-awawdi-amazon/valkey-glide
that referenced
this pull request
Oct 22, 2024
…-io#2459) Keep a single Runtime: `tokio` - Removed dead code for `async-std` - Fixed `redis-rs` tests so they could be run with a simple `cargo test` command - Changed the default features to include: "tokio-comp", "tokio-rustls-comp", "connection-manager", "cluster", "cluster-async" - Fixed a flaky `glide-core` test Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async-stdredis-rstest so they could be run withcargo testglide-coreflaky testNext step:
Remove the
tokio-*feature set and simply assume that it is always enabled.The goal is to remove all the "C" style
ifdefcoding style from theredis-rscode base and make it more readable and maintainable.