Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy failing #2453

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Fix mypy failing #2453

merged 3 commits into from
Oct 14, 2024

Conversation

shohamazon
Copy link
Collaborator

@shohamazon shohamazon commented Oct 14, 2024 •
edited
Loading

due to failing https://github.com/valkey-io/valkey-glide/actions/runs/11328568407/job/31502098614

Issue link

This Pull Request is linked to issue (URL): #2454

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • [ ] CHANGELOG.md and documentation files are updated. not needed
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@shohamazon
Fix mypy failing
09c130b 
Signed-off-by: Shoham Elias <shohame@amazon.com>
@shohamazon shohamazon requested a review from a team as a code owner October 14, 2024 13:39
@shohamazon
add anothe rtest
c7062e7 
Signed-off-by: Shoham Elias <shohame@amazon.com>
@shohamazon shohamazon self-assigned this Oct 14, 2024
@shohamazon shohamazon linked an issue Oct 14, 2024 that may be closed by this pull request
mypy fails on testing #2454
Closed
@shohamazon
black
fae5fba 
Signed-off-by: Shoham Elias <shohame@amazon.com>
@shohamazon shohamazon merged commit 3661f87 into valkey-io:release-1.2 Oct 14, 2024
11 checks passed
@shohamazon shohamazon deleted the mypy-fix branch October 14, 2024 14:40
Muhammad-awawdi-amazon pushed a commit that referenced this pull request Oct 15, 2024
@shohamazon @Muhammad-awawdi-amazon
Fix mypy failing (#2453)
172c8af 
---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 15, 2024
@shohamazon @Muhammad-awawdi-amazon
Fix mypy failing (valkey-io#2453)
98a86d7 
---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@shohamazon @avifenesh
Fix mypy failing (valkey-io#2453)
fdbd889 
---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Oct 21, 2024
Merged
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@shohamazon @avifenesh
Fix mypy failing (valkey-io#2453)
4efe51f 
---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
avifenesh pushed a commit that referenced this pull request Oct 22, 2024
@shohamazon @avifenesh
Fix mypy failing (#2453)
98a8c6c 
---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 22, 2024
@shohamazon @avifenesh
Fix mypy failing (valkey-io#2453)
f71052c 
---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 22, 2024
@shohamazon @Muhammad-awawdi-amazon
Fix mypy failing (valkey-io#2453)
838b34f 
---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
avifenesh added a commit that referenced this pull request Oct 22, 2024
@avifenesh @shohamazon
CI - Minimal and full CI matrix impl (#2051)
bcc6b00 
* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
avifenesh added a commit to avifenesh/valkey-glide that referenced this pull request Nov 3, 2024
@avifenesh @shohamazon
CI - Minimal and full CI matrix impl (valkey-io#2051)
72b6fcd 
* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (valkey-io#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (valkey-io#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
avifenesh added a commit to avifenesh/valkey-glide that referenced this pull request Nov 3, 2024
@avifenesh @shohamazon
CI - Minimal and full CI matrix impl (valkey-io#2051)
5d3be32 
* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (valkey-io#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (valkey-io#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
avifenesh added a commit to avifenesh/valkey-glide that referenced this pull request Nov 3, 2024
@avifenesh @shohamazon
CI - Minimal and full CI matrix impl (valkey-io#2051)
629190c 
* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (valkey-io#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (valkey-io#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
avifenesh added a commit to avifenesh/valkey-glide that referenced this pull request Nov 5, 2024
@avifenesh @shohamazon
CI - Minimal and full CI matrix impl (valkey-io#2051)
fee8d29 
* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (valkey-io#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (valkey-io#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
avifenesh added a commit to avifenesh/valkey-glide that referenced this pull request Nov 5, 2024
@avifenesh @shohamazon
CI - Minimal and full CI matrix impl (valkey-io#2051)
e801c03 
* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (valkey-io#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (valkey-io#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
avifenesh added a commit to avifenesh/valkey-glide that referenced this pull request Nov 5, 2024
@avifenesh @shohamazon
CI - Minimal and full CI matrix impl (valkey-io#2051)
7a05d97 
* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (valkey-io#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (valkey-io#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
avifenesh added a commit that referenced this pull request Nov 5, 2024
@avifenesh @Yury-Fridlyand @shohamazon
Merge ci from main (#2584)
2b6578a 
* Update README.md nodejs platform support (#2397)

* Update README.md

Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Update README.md - lint fix

Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Update README.md ling

Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Update node/README.md

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

---------

Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* CI - Minimal and full CI matrix impl (#2051)

* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

* CI - Minimal and full CI matrix impl (#2051)

* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

* CI - Minimal and full CI matrix impl (#2051)

* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

* Fix for - Minimal and full CI matrix impl #2051 (#2500)

* Refactor tests to use async cleanup and improve error handling

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Enhance Jest configuration and add test setup file; update build scripts and dependencies

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Update devDependencies in package.json for hybrid-node-tests to latest versions

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Enhance test utilities and command tests with improved wait logic and version checks

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Refactor tests to assert expected replica reads are less than or equal to actual reads; update connection handling in utilities and allow unused imports in types

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Update dependencies and enhance PyO3 bindings; add new features and improve type handling

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Update GitHub workflows: enhance linting configurations, adjust engine version requirements, and remove obsolete Redis installation workflow

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* fixes for CI (#2552)

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Refactor CI configuration for consistency and clarity

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Refactor CI configuration for consistency and clarity

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
acarbonetto pushed a commit that referenced this pull request Nov 5, 2024
@avifenesh @shohamazon @acarbonetto
CI - Minimal and full CI matrix impl (#2051)
e4e4a46 
* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikolomi ikolomi ikolomi approved these changes

Assignees

@shohamazon shohamazon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypy fails on testing
2 participants
@shohamazon @ikolomi