Added inflightRequestsLimit client config to Node #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0438a1f to
0281fab
Compare
Signed-off-by: GilboaAWS <gilboabg@amazon.com>
Signed-off-by: GilboaAWS <gilboabg@amazon.com>
0281fab to
bb66ebd
Compare
4 tasks
Muhammad-awawdi-amazon
pushed a commit
to Muhammad-awawdi-amazon/valkey-glide
that referenced
this pull request
Oct 15, 2024
* Added inflightRequestsLimit client config to Node --------- Signed-off-by: GilboaAWS <gilboabg@amazon.com> Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
avifenesh
pushed a commit
to avifenesh/valkey-glide
that referenced
this pull request
Oct 21, 2024
* Added inflightRequestsLimit client config to Node --------- Signed-off-by: GilboaAWS <gilboabg@amazon.com>
avifenesh
pushed a commit
to avifenesh/valkey-glide
that referenced
this pull request
Oct 21, 2024
* Added inflightRequestsLimit client config to Node --------- Signed-off-by: GilboaAWS <gilboabg@amazon.com>
Muhammad-awawdi-amazon
pushed a commit
to Muhammad-awawdi-amazon/valkey-glide
that referenced
this pull request
Oct 22, 2024
* Added inflightRequestsLimit client config to Node --------- Signed-off-by: GilboaAWS <gilboabg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for this client config inflightRequestsLimit
The maximum number of concurrent requests allowed to be in-flight (sent but not yet completed).
This limit is used to control the memory usage and prevent the client from overwhelming the server or getting stuck in case of a queue backlog.
If not set, a default value will be used.
Issue link
This Pull Request is linked to issue (URL): #1253
Checklist
Before submitting the PR make sure the following are checked: