Java: `FT.SEARCH` #2439

Yury-Fridlyand · 2024-10-11T18:32:27Z

Issue link

#2428

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Commits will be squashed upon merging.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

java/client/src/main/java/glide/api/models/commands/FT/FTSearchOptions.java

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

…yf-valkey-330-ft.search Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

java/client/src/main/java/glide/api/models/commands/FT/FTSearchOptions.java

acarbonetto

lgtm

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* `FT.CREATE` Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand added 2 commits October 11, 2024 11:27

FT.CREATE

70cc7dc

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

changelog

df70622

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand added the java issues and fixes related to the java client label Oct 11, 2024

Yury-Fridlyand added this to the 1.2 milestone Oct 11, 2024

Yury-Fridlyand requested a review from a team as a code owner October 11, 2024 18:32

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 11, 2024 18:32 — with GitHub Actions Error

This was referenced Oct 11, 2024

Java: VSS commands support #2428

Closed

Java: VSS commands init #2385

Closed

Yury-Fridlyand changed the title ~~Java: FT.CREATE~~ Java: FT.SEARCH Oct 11, 2024

Yury-Fridlyand added the 1_2_candidate label Oct 11, 2024

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 11, 2024 19:06 — with GitHub Actions Error

glidestring

516a714

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 11, 2024 19:08 — with GitHub Actions Error

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 11, 2024 19:08 — with GitHub Actions Failure

test fix

59e877b

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 11, 2024 19:15 — with GitHub Actions Error

Yury-Fridlyand temporarily deployed to AWS_ACTIONS October 11, 2024 19:15 — with GitHub Actions Inactive

prateek-kumar-improving reviewed Oct 11, 2024

View reviewed changes

java/client/src/main/java/glide/api/models/commands/FT/FTSearchOptions.java Outdated Show resolved Hide resolved

prateek-kumar-improving reviewed Oct 15, 2024

View reviewed changes

java/client/src/main/java/glide/api/models/commands/FT/FTSearchOptions.java Show resolved Hide resolved

Yury-Fridlyand added 2 commits October 16, 2024 11:22

Address PR review.

c32c9bc

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Merge remote-tracking branch 'upstream/release-1.2' into java/dev-yur…

85c5ed2

…yf-valkey-330-ft.search Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand temporarily deployed to AWS_ACTIONS October 16, 2024 18:27 — with GitHub Actions Inactive

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 16, 2024 18:27 — with GitHub Actions Error

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 16, 2024 19:37 — with GitHub Actions Error

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 16, 2024 19:56 — with GitHub Actions Error

Merge branch 'release-1.2' into java/dev-yuryf-valkey-330-ft.search

61636f5

Yury-Fridlyand temporarily deployed to AWS_ACTIONS October 16, 2024 21:20 — with GitHub Actions Inactive

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 16, 2024 21:20 — with GitHub Actions Error

Fix examples

d65da25

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand temporarily deployed to AWS_ACTIONS October 17, 2024 17:20 — with GitHub Actions Inactive

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 17, 2024 17:20 — with GitHub Actions Error

prateek-kumar-improving reviewed Oct 17, 2024

View reviewed changes

java/client/src/main/java/glide/api/models/commands/FT/FTSearchOptions.java Outdated Show resolved Hide resolved

prateek-kumar-improving approved these changes Oct 17, 2024

View reviewed changes

acarbonetto approved these changes Oct 17, 2024

View reviewed changes

Address PR review.

bd0621d

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand temporarily deployed to AWS_ACTIONS October 17, 2024 17:40 — with GitHub Actions Inactive

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 17, 2024 17:40 — with GitHub Actions Error

Fix examples

33ead80

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 17, 2024 17:45 — with GitHub Actions Error

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 17, 2024 17:45 — with GitHub Actions Failure

typo fix

9077a66

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand temporarily deployed to AWS_ACTIONS October 17, 2024 18:03 — with GitHub Actions Inactive

Yury-Fridlyand had a problem deploying to AWS_ACTIONS October 17, 2024 18:03 — with GitHub Actions Failure

Yury-Fridlyand merged commit c252cbb into release-1.2 Oct 17, 2024
34 of 35 checks passed

Yury-Fridlyand deleted the java/dev-yuryf-valkey-330-ft.search branch October 17, 2024 18:30

avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024

Java: FT.SEARCH (valkey-io#2439)

98bd11e

* `FT.CREATE` Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024

Java: FT.SEARCH (valkey-io#2439)

6fa6305

* `FT.CREATE` Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 22, 2024

Java: FT.SEARCH (valkey-io#2439)

46ff569

* `FT.CREATE` Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java: `FT.SEARCH` #2439

Java: `FT.SEARCH` #2439

Yury-Fridlyand commented Oct 11, 2024 •

edited

Loading

acarbonetto left a comment

Java: FT.SEARCH #2439

Java: FT.SEARCH #2439

Conversation

Yury-Fridlyand commented Oct 11, 2024 • edited Loading

Issue link

Checklist

acarbonetto left a comment

Choose a reason for hiding this comment

Java: `FT.SEARCH` #2439

Java: `FT.SEARCH` #2439

Yury-Fridlyand commented Oct 11, 2024 •

edited

Loading