New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python `FT.DROPINDEX` command #2437

Merged

acarbonetto merged 14 commits into release-1.2 from python-ft-dropindex

Oct 15, 2024

Collaborator

prateek-kumar-improving commented Oct 11, 2024 •

edited

Loading

Issue link

This Pull Request is linked to issue (URL): #2429

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Commits will be squashed upon merging.

prateek-kumar-improving added 2 commits

October 11, 2024 00:34


          Python [FT.DROPINDEX] Added command

6351a9e

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>


          Python [FT.DROPINDEX] Add examples

29b5881

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving requested a review from a team as a code owner

October 11, 2024 17:06

prateek-kumar-improving had a problem deploying to AWS_ACTIONS

October 11, 2024 17:06

— with

GitHub Actions Error

prateek-kumar-improving mentioned this pull request

Python: VSS commands support #2429

Closed

14 tasks

prateek-kumar-improving added the python label

prateek-kumar-improving requested review from Yury-Fridlyand, acarbonetto and shohamazon

October 11, 2024 17:09

prateek-kumar-improving changed the title ~~Python ft dropindex~~ Python FT.DROPINDEX command


          Updated CHANGELOG.md

20c0c32

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS

October 11, 2024 17:35

— with

GitHub Actions Error

jamesx-improving reviewed

View reviewed changes

python/python/tests/tests_server_modules/search/test_ft_dropindex.py Show resolved Hide resolved

jamesx-improving approved these changes

View reviewed changes

Collaborator

jamesx-improving left a comment

Approved if comment addressed.

prateek-kumar-improving added 2 commits

October 11, 2024 14:37


          Python [FT.DROPINDEX] Example updated

50eae22

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>


          Merge branch 'release-1.2' into python-ft-dropindex

315e0fd

prateek-kumar-improving had a problem deploying to AWS_ACTIONS

October 11, 2024 21:38

— with

GitHub Actions Failure

prateek-kumar-improving temporarily deployed to AWS_ACTIONS

October 11, 2024 22:23

— with

GitHub Actions Inactive

acarbonetto approved these changes

View reviewed changes

python/python/glide/async_commands/server_modules/ft.py Outdated Show resolved Hide resolved


          Python [FT.DROPINDEX] Update documentation

efdf4ae

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving temporarily deployed to AWS_ACTIONS

October 11, 2024 23:31

— with

GitHub Actions Inactive

acarbonetto reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/ft.py Outdated Show resolved Hide resolved


          Python [FT.DROPINDEX] documentation updated

0e98fbb

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving temporarily deployed to AWS_ACTIONS

October 11, 2024 23:45

— with

GitHub Actions Inactive


          Python [FT.DROPINDEX] Update return documentation

26435d8

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS

October 12, 2024 00:22

— with

GitHub Actions Error

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/ft.py Outdated Show resolved Hide resolved

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/ft.py Outdated Show resolved Hide resolved

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/ft.py Outdated Show resolved Hide resolved

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/ft.py Outdated Show resolved Hide resolved


          Review comments fixed

03e35be

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS

October 14, 2024 03:57

— with

GitHub Actions Error


          Python FT.CREATE related code cleanup

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS

October 14, 2024 06:26

— with

GitHub Actions Error


          Python ft_constants.py file moved to options

c2f904c

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS

October 14, 2024 06:42

— with

GitHub Actions Error


          Python ft_constants.py reformatted

27c4539

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS

October 14, 2024 06:48

— with

GitHub Actions Error


          Merge branch 'release-1.2' into python-ft-dropindex

380b927

prateek-kumar-improving had a problem deploying to AWS_ACTIONS

October 15, 2024 07:38

— with

GitHub Actions Error


          Merge branch 'release-1.2' into python-ft-dropindex

afff7a9

prateek-kumar-improving temporarily deployed to AWS_ACTIONS

October 15, 2024 17:01

— with

GitHub Actions Inactive

acarbonetto merged commit 23a180b into release-1.2

12 checks passed

acarbonetto deleted the python-ft-dropindex branch

October 15, 2024 18:33

prateek-kumar-improving changed the title ~~Python FT.DROPINDEX command~~ Python FT.DROPINDEX command

avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request


          Python FT.DROPINDEX command (valkey-io#2437)

0670a6e

* Python [FT.DROPINDEX] Added command

---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request


          Python FT.DROPINDEX command (valkey-io#2437)

de7d47a

* Python [FT.DROPINDEX] Added command

---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request


          Python FT.DROPINDEX command (valkey-io#2437)

63d2c59

* Python [FT.DROPINDEX] Added command

---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python