-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added inflightRequestsLimit client config to java #2408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GilboaAWS <gilboabg@amazon.com>
4 tasks
Yury-Fridlyand
approved these changes
Oct 9, 2024
java/client/src/main/java/glide/api/models/configuration/BaseClientConfiguration.java
Outdated
Show resolved
Hide resolved
…lientConfiguration.java Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Gilboab <97948000+GilboaAWS@users.noreply.github.com>
GilboaAWS
force-pushed
the
add_inflight_java
branch
from
October 10, 2024 10:11
80155cf
to
dd35d35
Compare
GilboaAWS
added a commit
to GilboaAWS/glide-for-redis
that referenced
this pull request
Oct 10, 2024
* Add inflight request limit config to java Signed-off-by: GilboaAWS <gilboabg@amazon.com>
GilboaAWS
added a commit
to GilboaAWS/glide-for-redis
that referenced
this pull request
Oct 10, 2024
* Add inflight request limit config to java Signed-off-by: GilboaAWS <gilboabg@amazon.com>
shohamazon
pushed a commit
that referenced
this pull request
Oct 10, 2024
* Add inflight request limit config to java Signed-off-by: GilboaAWS <gilboabg@amazon.com>
acarbonetto
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Oct 10, 2024
* Add inflight request limit config to java Signed-off-by: GilboaAWS <gilboabg@amazon.com>
cyip10
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Add inflight request limit config to java Signed-off-by: GilboaAWS <gilboabg@amazon.com>
cyip10
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Add inflight request limit config to java Signed-off-by: GilboaAWS <gilboabg@amazon.com> Signed-off-by: Chloe <chloe.yip@improving.com>
GilboaAWS
added a commit
to GilboaAWS/glide-for-redis
that referenced
this pull request
Oct 13, 2024
* Add inflight request limit config to java Signed-off-by: GilboaAWS <gilboabg@amazon.com>
ikolomi
pushed a commit
that referenced
this pull request
Oct 13, 2024
Added inflightRequestsLimit client config to java (#2408) * Add inflight request limit config to java Signed-off-by: GilboaAWS <gilboabg@amazon.com>
Muhammad-awawdi-amazon
pushed a commit
that referenced
this pull request
Oct 14, 2024
Added inflightRequestsLimit client config to java (#2408) * Add inflight request limit config to java Signed-off-by: GilboaAWS <gilboabg@amazon.com>
Muhammad-awawdi-amazon
pushed a commit
to Muhammad-awawdi-amazon/valkey-glide
that referenced
this pull request
Oct 15, 2024
Added inflightRequestsLimit client config to java (valkey-io#2408) * Add inflight request limit config to java Signed-off-by: GilboaAWS <gilboabg@amazon.com> Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for this client config
inflightRequestsLimit
The maximum number of concurrent requests allowed to be in-flight (sent but not yet completed).
This limit is used to control the memory usage and prevent the client from overwhelming the server or getting stuck in case of a queue backlog.
If not set, a default value will be used.