Replace google-api-python-client by protobuf #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5123865 to
7934dfe
Compare
|
@Rafiot could you please push your branch to this repo? We need to confirm that module test CI also passes. It runs only on a branches on this repository (not on forks). Please also add changelog entry. |
|
@Yury-Fridlyand I don't have write access so I cannot push a branch directly. I'll update the changelog. |
Signed-off-by: Raphaël Vinot <raphael@vinot.info>
7934dfe to
fb11d05
Compare
|
I run CI for you, all pass: https://github.com/valkey-io/valkey-glide/actions/runs/10909859375 |
Yury-Fridlyand
approved these changes
Sep 17, 2024
|
LGTM |
|
\o/ Thank you! |
shohamazon
pushed a commit
to shohamazon/glide-for-redis
that referenced
this pull request
Sep 22, 2024
Replace google-api-python-client with protobuf Signed-off-by: Raphaël Vinot <raphael@vinot.info>
ikolomi
pushed a commit
that referenced
this pull request
Sep 23, 2024
Replace google-api-python-client with protobuf Signed-off-by: Raphaël Vinot <raphael@vinot.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me prefix that one by saying that I haven't been testing it extensively, it just seems to be working as expected.
This PR would fix #2298. Can you just trigger the test suite and see what happens? They seem to be passing fine there: https://github.com/Rafiot/valkey-glide/actions/runs/10905533315