Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add binary support for HSCAN #2240

Merged

Conversation

jonathanl-bq
Copy link
Collaborator

Affects HSCAN command only.

Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
@jonathanl-bq jonathanl-bq added the node Node.js wrapper label Sep 6, 2024
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
@jonathanl-bq jonathanl-bq marked this pull request as ready for review September 6, 2024 18:35
@jonathanl-bq jonathanl-bq requested a review from a team as a code owner September 6, 2024 18:35
@jonathanl-bq jonathanl-bq merged commit 79fdec5 into valkey-io:main Sep 6, 2024
9 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/lotjonat_valkey_299_hscan_binary branch September 7, 2024 01:03
janhavigupta007 pushed a commit to janhavigupta007/glide-for-redis that referenced this pull request Sep 11, 2024
* Add binary support for HSCAN

Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>

* Update CHANGELOG

Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>

* Run Prettier

Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>

* Change hscan test resultValues to GlideStrings

Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>

* Use convert results to strings for hscan tests

Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>

* Run Prettier

Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>

* Convert a few more hscan test results to strings

Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>

* Run Prettier

Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>

---------

Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants