Node: Add binary variant to connection management commands. #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
GumpacG
approved these changes
Aug 20, 2024
acarbonetto
reviewed
Aug 20, 2024
| { route: toProtobufRoute(route) }, | ||
| { | ||
| route: toProtobufRoute(options?.route), | ||
| decoder: options?.decoder, |
There was a problem hiding this comment.
nit:
...options
should accomplish the same thing
There was a problem hiding this comment.
unfortunately, not, because both have route but in different type
…60-conn-bin Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
yipin-chen
reviewed
Aug 21, 2024
Co-authored-by: Yi-Pin Chen <yi-pin.chen@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…60-conn-bin Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
acarbonetto
approved these changes
Aug 23, 2024
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…60-conn-bin Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
liorsve
pushed a commit
to liorsve/valkey-glide
that referenced
this pull request
Aug 25, 2024
…o#2160) * Add binary variant to connection management commands. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yi-Pin Chen <yi-pin.chen@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
liorsve
pushed a commit
to liorsve/valkey-glide
that referenced
this pull request
Aug 25, 2024
…o#2160) * Add binary variant to connection management commands. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yi-Pin Chen <yi-pin.chen@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLIENT GETNAMECLIENT IDECHOPING(update)SELECTAnd
WATCHUNWATCH