Node: Update tests for blocking commands. #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
acarbonetto
reviewed
Aug 14, 2024
avifenesh
reviewed
Aug 15, 2024
node/tests/SharedTests.ts
Outdated
| const timeoutPromise = new Promise((resolve) => { | ||
| setTimeout(resolve, 500); | ||
| }); | ||
| await Promise.race([promise, timeoutPromise]); |
There was a problem hiding this comment.
Not sure if I understand the test, how do you know which one has resolved?
If I understand, what the test does is checking if at least one of the promises has resolved.
Then you resolve all the promises, if they are blocked and never timed out, we expect it to never resolve right?
So how the test doing it?
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
avifenesh
approved these changes
Aug 18, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
acarbonetto
approved these changes
Aug 22, 2024
prateek-kumar-improving
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Aug 22, 2024
* Update tests for blocking commands. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
liorsve
pushed a commit
to liorsve/valkey-glide
that referenced
this pull request
Aug 25, 2024
* Update tests for blocking commands. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
liorsve
pushed a commit
to liorsve/valkey-glide
that referenced
this pull request
Aug 25, 2024
* Update tests for blocking commands. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to shared test, add version check and add more commands to check