Node: Add XINFO STREAM command
#2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b50a719 to
5b8a668
Compare
node/src/BaseClient.ts
Outdated
| * // 'seen-time': 1722624726802, | ||
| * // 'active-time': 1722624726802, | ||
| * // 'pel-count': 1, | ||
| * // pending: [ [ '1719877599564-0', 'consumer', 1722624726802, 1 ] ], |
There was a problem hiding this comment.
Suggested change
| * // pending: [ [ '1719877599564-0', 'consumer', 1722624726802, 1 ] ], | |
| * // 'pending': [ [ '1719877599564-0', 1722624726802, 1 ] ], |
There was a problem hiding this comment.
quotes are only necessary for keys that have dashes. This is the output produced by VS Code.
There was a problem hiding this comment.
We still don't have here consumer name
There was a problem hiding this comment.
for full details, you get the consumer name... according to the shared testes.
There was a problem hiding this comment.
Yes, but consumer name isn't duplicated per each consumer
GumpacG
approved these changes
Aug 6, 2024
Yury-Fridlyand
approved these changes
Aug 6, 2024
node/src/BaseClient.ts
Outdated
| * // 'seen-time': 1722624726802, | ||
| * // 'active-time': 1722624726802, | ||
| * // 'pel-count': 1, | ||
| * // pending: [ [ '1719877599564-0', 'consumer', 1722624726802, 1 ] ], |
There was a problem hiding this comment.
Yes, but consumer name isn't duplicated per each consumer
a2f4503 to
e42c828
Compare
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
e42c828 to
6af2cab
Compare
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Aug 12, 2024
* Node: Add XINFO STREAM command --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XINFO STREAM