Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: implement MSETNX #2046

Merged
merged 10 commits into from
Jul 30, 2024
Merged

Node: implement MSETNX #2046

merged 10 commits into from
Jul 30, 2024

Conversation

cyip10
Copy link
Collaborator

@cyip10 cyip10 commented Jul 29, 2024

@cyip10
implement msetnx
20ea28d 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10 cyip10 requested a review from a team as a code owner July 29, 2024 23:01
cyip10 added 2 commits July 29, 2024 16:02
@cyip10
add changelog
98f825c 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10
remove import in shared tests
7963e9a 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label Jul 29, 2024
Yury-Fridlyand
Yury-Fridlyand reviewed Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a cross slot test

node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Show resolved Hide resolved
cyip10 added 2 commits July 29, 2024 16:23
@cyip10
add cross slot test and address comments
aca6146 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10
ran linter
aea7f97 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
cyip10 added 3 commits July 29, 2024 18:47
@cyip10
add more to cross slot
70d4fca 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10
add more to cross slot
9cfb169 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
@cyip10
ran linter
cc7b05c 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
GumpacG
GumpacG approved these changes Jul 30, 2024
View reviewed changes
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Show resolved Hide resolved
aaron-congo
aaron-congo reviewed Jul 30, 2024
View reviewed changes
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Show resolved Hide resolved
@cyip10
address new comments
1d50b4b 
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
yipin-chen
yipin-chen approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please address outstanding comments. I have re-run the failed CI test. It is all green now.

@cyip10
Merge branch 'main' into node/integ_cyip10_msetnx
5dd92ce 
Signed-off-by: Chloe Yip <168601573+cyip10@users.noreply.github.com>
@cyip10 cyip10 merged commit 8c84971 into valkey-io:main Jul 30, 2024
8 checks passed
@cyip10 cyip10 deleted the node/integ_cyip10_msetnx branch July 30, 2024 21:00
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yipin-chen yipin-chen yipin-chen approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@aaron-congo aaron-congo aaron-congo approved these changes

@GumpacG GumpacG GumpacG approved these changes

Assignees
No one assigned
Labels
node Node.js wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyip10 @GumpacG @aaron-congo @Yury-Fridlyand @yipin-chen