Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: XRange/XRevRange should return null instead of GlideException when given a non-positive count #1920

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Java: XRange/XRevRange should return null instead of GlideException when given a non-positive count #1920

merged 3 commits into from
Jul 23, 2024

Conversation

acarbonetto
Copy link
Contributor

XRange and XRevRange will thrown an error when count is less than or equal to zero:

GlideException: Unexpected return type from Glide: got null expected Map

@acarbonetto acarbonetto added bug Something isn't working java issues and fixes related to the java client labels Jul 10, 2024
@acarbonetto acarbonetto self-assigned this Jul 10, 2024
@acarbonetto acarbonetto requested a review from a team as a code owner July 10, 2024 21:15
alexey-temnikov
alexey-temnikov reviewed Jul 10, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
alexey-temnikov
alexey-temnikov approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@alexey-temnikov alexey-temnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider addressing minor nit. The rest LGTM.

@acarbonetto acarbonetto changed the title Java: Fix xrange/xrevrange when given a negative count Java: XRange/XRevRange should return null instead of GlideException when given a negative count Jul 10, 2024
@Yury-Fridlyand
Copy link
Collaborator

Please resolve the conflict

Yury-Fridlyand
Yury-Fridlyand reviewed Jul 23, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@acarbonetto
Java: Fix xrange/xrevrange
7ba90eb 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto
Fix changelog
82f14ca 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto
Update changelog
f0e9a29 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto acarbonetto force-pushed the java/integ_acarbo_bug_xrange_xrevrange_negative_count branch from 9d5b59d to f0e9a29 Compare July 23, 2024 20:04
@acarbonetto acarbonetto merged commit 861019c into valkey-io:main Jul 23, 2024
6 checks passed
@acarbonetto acarbonetto deleted the java/integ_acarbo_bug_xrange_xrevrange_negative_count branch July 23, 2024 20:28
@asafpamzn asafpamzn mentioned this pull request Aug 11, 2024
Closed
10 tasks
@jonathanl-bq jonathanl-bq changed the title Java: XRange/XRevRange should return null instead of GlideException when given a negative count Java: XRange/XRevRange should return null instead of GlideException when given a non-positive count Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

@alexey-temnikov alexey-temnikov alexey-temnikov approved these changes

Assignees

@acarbonetto acarbonetto

Labels
bug Something isn't working java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acarbonetto @Yury-Fridlyand @alexey-temnikov @yipin-chen