-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: add FUNCTION DUMP and FUNCTION RESTORE commands #1769
Merged
acarbonetto
merged 9 commits into
valkey-io:main
from
Bit-Quill:python/dev_yipin_function_dump_restore
Jul 3, 2024
Merged
Python: add FUNCTION DUMP and FUNCTION RESTORE commands #1769
acarbonetto
merged 9 commits into
valkey-io:main
from
Bit-Quill:python/dev_yipin_function_dump_restore
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this to transaction or not yet?
aaron-congo
reviewed
Jul 3, 2024
I will create a different PR to address transacations for Dump, Restore, Function Dump, and Function Restore commands. |
yipin-chen
force-pushed
the
python/dev_yipin_function_dump_restore
branch
from
July 3, 2024 18:18
9f98e66
to
dc091a5
Compare
Yury-Fridlyand
approved these changes
Jul 3, 2024
aaron-congo
reviewed
Jul 3, 2024
Elen-Ghulam
approved these changes
Jul 3, 2024
acarbonetto
approved these changes
Jul 3, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jul 4, 2024
* Initial commit for function dump and restore commands * Split UT to standalone and cluster tests * Fixed mypy errors * Addressed review comments * Addressed review comment * Addressed review comments * Updated examples
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jul 16, 2024
* Initial commit for function dump and restore commands * Split UT to standalone and cluster tests * Fixed mypy errors * Addressed review comments * Addressed review comment * Addressed review comments * Updated examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/function-dump/
https://redis.io/docs/latest/commands/function-restore/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.