Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: add FUNCTION DUMP and FUNCTION RESTORE commands #1769

Merged

Conversation

yipin-chen
Copy link
Collaborator

Issue #, if available:
N/A

Description of changes:
https://redis.io/docs/latest/commands/function-dump/
https://redis.io/docs/latest/commands/function-restore/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yipin-chen yipin-chen marked this pull request as ready for review July 3, 2024 13:52
@yipin-chen yipin-chen requested a review from a team as a code owner July 3, 2024 13:52
@Yury-Fridlyand Yury-Fridlyand added the python Python wrapper label Jul 3, 2024
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to transaction or not yet?

python/python/glide/async_commands/core.py Show resolved Hide resolved
python/python/glide/async_commands/cluster_commands.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/standalone_commands.py Outdated Show resolved Hide resolved
@yipin-chen yipin-chen closed this Jul 3, 2024
@yipin-chen yipin-chen reopened this Jul 3, 2024
@yipin-chen
Copy link
Collaborator Author

Can you add this to transaction or not yet?

I will create a different PR to address transacations for Dump, Restore, Function Dump, and Function Restore commands.

@yipin-chen yipin-chen force-pushed the python/dev_yipin_function_dump_restore branch from 9f98e66 to dc091a5 Compare July 3, 2024 18:18
@acarbonetto acarbonetto merged commit 90803cd into valkey-io:main Jul 3, 2024
20 checks passed
@acarbonetto acarbonetto deleted the python/dev_yipin_function_dump_restore branch July 3, 2024 23:02
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jul 4, 2024
* Initial commit for function dump and restore commands

* Split UT to standalone and cluster tests

* Fixed mypy errors

* Addressed review comments

* Addressed review comment

* Addressed review comments

* Updated examples
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jul 16, 2024
* Initial commit for function dump and restore commands

* Split UT to standalone and cluster tests

* Fixed mypy errors

* Addressed review comments

* Addressed review comment

* Addressed review comments

* Updated examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python wrapper
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants