-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Add HSCAN command #1706
Merged
Merged
Java: Add HSCAN command #1706
Changes from 38 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
29914cb
Java: Add `SSCAN` command (#394)
GumpacG 51f3e35
Java: Add `ZSCAN` command (#397)
GumpacG 878facc
WIP TODO: support transactions, docs, and more IT
GumpacG f028224
Added more tests
GumpacG 79ce6fd
Added tests and javadocs
GumpacG 9f76d08
Improved examples and tests
GumpacG 0f69477
Correct use of SScanOptions instead of ScanOptions for SScan
jduo 343c7ad
Remove plumbing for SCAN command
jduo 851d952
Sleep after sadd() calls before sscan() calls
jduo c708547
Change sscan cursor to be a String
jduo 450e17d
WIP with todos
GumpacG da923a4
Add ZScan to TransactionTestUtilities
jduo 01c0794
Spotless cleanup
jduo ae014e5
Test fixes
jduo e65a9f7
Cleanup test code
jduo 90cad59
Added better error info for set comparison failures
jduo 213a873
More logging for test failures
jduo bb49b58
Add sleeps after zadd() calls
jduo e1bed7c
Longer sleeps
jduo 3406cd8
Reduce wait time
jduo b908a0b
Experiment with unsigned 64-bit cursors
jduo 7ba31b6
Fix rebase error
jduo cf86bfd
WIP TODO: support transactions, docs, and more IT
GumpacG 1de0e9d
Added more tests
GumpacG 43764ec
Added tests and javadocs
GumpacG fe4162f
Improved examples and tests
GumpacG 2f73165
Sleep after sadd() calls before sscan() calls
jduo fc028cd
Change sscan cursor to be a String
jduo cdd69b0
Fix rebase conflicts
jduo a0f1158
Fix another rebase conflict
jduo e49be9f
Spotless
jduo 3a0f696
HScan
jduo f410531
Flakey test
jduo c9ec010
Add HScan transaction unit test
jduo 241ef45
Rename ScanOptions to BaseScanOptions
jduo fc2a4d1
Fix merge issues
jduo 7eef0c1
Fix module-info ordering
jduo f1429ac
Tidy up docs
jduo b959c6c
PR comments
jduo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -240,6 +240,7 @@ enum RequestType { | |
XGroupSetId = 199; | ||
SScan = 200; | ||
ZScan = 201; | ||
HScan = 202; | ||
} | ||
|
||
message Command { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
java/client/src/main/java/glide/api/models/commands/scan/HScanOptions.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/** Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0 */ | ||
package glide.api.models.commands.scan; | ||
|
||
import glide.api.commands.HashBaseCommands; | ||
import lombok.experimental.SuperBuilder; | ||
|
||
/** | ||
* Optional arguments for {@link HashBaseCommands#hscan(String, String, HScanOptions)}. | ||
* | ||
* @see <a href="https://valkey.io/commands/hscan/">valkey.io</a> | ||
*/ | ||
@SuperBuilder | ||
public class HScanOptions extends BaseScanOptions {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️