Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: adds TOUCH command #1582

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

shohamazon
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shohamazon shohamazon requested a review from a team as a code owner June 16, 2024 12:52
@shohamazon shohamazon added the python Python wrapper label Jun 16, 2024
@@ -429,6 +429,8 @@ async def set(
args.append("GET")
if expiry is not None:
args.extend(expiry.get_cmd_args())

print(args)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😶

See https://valkey.io/commands/touch/ for details.

Note:
When in cluster mode, the command may route to multiple nodes when `keys` map to different hash slots.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

Copy link
Contributor

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address comments before merging

keys (List[str]): The keys to update last access time.

Returns:
int: The number of keys that were updated, a key is ignored is it doesn't exist.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int: The number of keys that were updated, a key is ignored is it doesn't exist.
int: The number of keys that were updated, a key is ignored if it doesn't exist.

keys (List[str]): The keys to update last access time.

Commands response:
int: The number of keys that were updated, a key is ignored is it doesn't exist.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int: The number of keys that were updated, a key is ignored is it doesn't exist.
int: The number of keys that were updated, a key is ignored if it doesn't exist.

python/python/tests/test_async_client.py Show resolved Hide resolved
@shohamazon shohamazon merged commit 18cb8aa into valkey-io:main Jun 18, 2024
6 checks passed
@shohamazon shohamazon deleted the python/touch branch June 18, 2024 08:48
acarbonetto pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 18, 2024
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 19, 2024
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python wrapper
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants