Python: adds GEOHASH command #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cef2706 to
ca8c895
Compare
Yury-Fridlyand
approved these changes
Apr 15, 2024
| async def geohash(self, key: str, members: List[str]) -> List[Optional[str]]: | ||
| """ | ||
| Returns the GeoHash strings representing the positions of all the specified members in the sorted set stored at | ||
| `key`. If a member does not exist in the sorted set, a None value is returned for that member. |
There was a problem hiding this comment.
Suggested change
| `key`. If a member does not exist in the sorted set, a None value is returned for that member. | |
| `key`. If a member does not exist in the sorted set, a `None` value is returned for that member. |
There was a problem hiding this comment.
Move this sentence to Returns section
Comment on lines
1584
to
1585
| >>> await client.geoadd("my_geo_sorted_set", {"Palermo": Coordinate(13.361389, 38.115556), "Catania": Coordinate(15.087269, 37.502669)}) | ||
| 2 # Indicates that two elements have been added to the sorted set "my_geo_sorted_set". |
There was a problem hiding this comment.
I think you can omit this
| def geohash(self: TTransaction, key: str, members: List[str]) -> TTransaction: | ||
| """ | ||
| Returns the GeoHash strings representing the positions of all the specified members in the sorted set stored at | ||
| `key`. If a member does not exist in the sorted set, a None value is returned for that member. |
ikolomi
reviewed
Apr 17, 2024
| @@ -131,6 +131,23 @@ class UpdateOptions(Enum): | |||
| GREATER_THAN = "GT" | |||
|
|
|||
|
|
|||
| class Coordinate: | |||
There was a problem hiding this comment.
this is an incorrect term - coordinate is a verb.
Suggesting GeospatialData
ikolomi
reviewed
Apr 17, 2024
| Adds geospatial members with their positions to the specified sorted set stored at `key`. | ||
| If a member is already a part of the sorted set, its position is updated. | ||
|
|
||
| See https://redis.io/commands/geoadd for more details. |
db75ef5 to
f53e261
Compare
ikolomi
approved these changes
Apr 18, 2024
f53e261 to
9859138
Compare
aaron-congo
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Apr 22, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This pr is rebased over #1259
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.