Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Add PFADD command. #1221

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

Issue #, if available:
N/A

Description of changes:
Add HyperHyperLogLog command PFADD - https://redis.io/commands/pfadd/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Add `PFADD` command.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* cleanup

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Add a test.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Minor fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Add transaction IT.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Address PR feedback.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* PR comments.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* PR comments.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Apr 2, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner April 2, 2024 21:15
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Elen-Ghulam Elen-Ghulam removed their assignment Apr 4, 2024
@Yury-Fridlyand Yury-Fridlyand merged commit c37238e into valkey-io:main Apr 4, 2024
45 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/integ_yuryf_pfadd branch April 4, 2024 17:51
shohamazon pushed a commit to adanWattad/glide-for-redis that referenced this pull request Apr 9, 2024
* Add `PFADD` command. (valkey-io#166)

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
shohamazon pushed a commit to adanWattad/glide-for-redis that referenced this pull request Apr 9, 2024
* Add `PFADD` command. (valkey-io#166)

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
* Add `PFADD` command. (#166)

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants