Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust core] multi key command with no arguments, in cluster mode, panics #2714

Closed
eifrah-aws opened this issue Nov 19, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working Release blocker Can't release without.
Milestone

Comments

@eifrah-aws
Copy link
Contributor

Consider the following example (in python, but crashes in every binding):

# Use full path
addresses = [NodeAddress("127.0.0.1", 7000), NodeAddress("127.0.0.1", 8000)]
config = GlideClusterClientConfiguration(addresses)
client = await GlideClusterClient.create(config)

for i in range(10000):
    response = await client.mset({})
    if "ERR" in response:
        print(f"error: {response}")

Same code using standalone client, (GlideClient) reports a proper error message:

lide.exceptions.RequestError: An error was signalled by the server - ResponseError: wrong number of arguments for 'mset' command
@eifrah-aws eifrah-aws added Release blocker Can't release without. 1_2_candidate labels Nov 19, 2024
@eifrah-aws eifrah-aws self-assigned this Nov 19, 2024
eifrah-aws added a commit to eifrah-aws/glide-for-redis that referenced this issue Nov 19, 2024
… behavior as the standalone client

(and it will also report a meaningful error to the log)

    Fixes: valkey-io#2714

Signed-off-by: Eran Ifrah <eifrah@amazon.com>
eifrah-aws added a commit to eifrah-aws/glide-for-redis that referenced this issue Nov 19, 2024
… behavior as the standalone client

(and it will also report a meaningful error to the log)

    Fixes: valkey-io#2714

Signed-off-by: Eran Ifrah <eifrah@amazon.com>
@eifrah-aws eifrah-aws moved this to In Progress in Valkey-GLIDE - internal Nov 20, 2024
@eifrah-aws eifrah-aws added this to the 1.2 milestone Nov 20, 2024
@ikolomi ikolomi added the bug Something isn't working label Nov 20, 2024
@avifenesh avifenesh mentioned this issue Nov 24, 2024
15 tasks
@eifrah-aws
Copy link
Contributor Author

Fixed with this PR: #2715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Release blocker Can't release without.
Projects
Status: Done
Development

No branches or pull requests

2 participants