Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/german mobile phone validation #1675

Closed

Conversation

Burnett01
Copy link

fix(isMobilePhone) german: Restrict leading zero when country code +49 is used

This PR ensures that german mobile phone numbers are deemed invalid when the country code (+49) is used with a leading 0.

Example:

Invalid: +4901575663214
Valid: +491575663214

See #1670

Checklist

  • [x ] PR contains only changes related; no stray files, etc.
  • [x ] README updated (where applicable)
  • [x ] Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #1675 (3e0742f) into master (907bb07) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1675   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          101       101           
  Lines         1854      1854           
=========================================
  Hits          1854      1854           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907bb07...3e0742f. Read the comment docs.

@profnandaa
Copy link
Member

Sorry this was already addressed in #1679 and sorry for late review // but thanks for your contribution!

@profnandaa profnandaa closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants