Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid phone number from Switzerland #1549

Closed
seyfer opened this issue Dec 10, 2020 · 1 comment · Fixed by #1554
Closed

Valid phone number from Switzerland #1549

seyfer opened this issue Dec 10, 2020 · 1 comment · Fixed by #1554
Labels
🐛 bug good first issue help needed

Comments

@seyfer
Copy link

seyfer commented Dec 10, 2020 •
edited
Loading

When validator used like that
isMobilePhone(value, 'any', { strictMode: false })

For the valid phone number from Switzerland +411122112211

it returns false. expected true.

on the other hand, our BE uses simple regex for Phone validation '/^\+([0-9]){8,16}$/' and it pass.
@profnandaa
Copy link
Member

PR welcome.

@ashut0shk ashut0shk mentioned this issue Dec 14, 2020
Merged
3 tasks
profnandaa pushed a commit that referenced this issue Dec 17, 2020
feat(isMobilePhone): update de-CH, add fr-CH, it-CH locales (#1554)
738cf60 
* fix(isMobilePhone): update de-CH locale (#1549)
feat(isMobilePhone): add fr-CH locale (#1549)
feat(isMobilePhone): add it-CH locale (#1549)

* fix(isMobilePhone): update de-CH, fr-CH and it-CH locale in validator.min.js(#1549)

* fix(isMobilePhone): update fr-CH and it-CH locale aliases (#1549)

Co-authored-by: Ashutosh Kumar <kumar.ashutosh@siemens.com>
profnandaa pushed a commit that referenced this issue Feb 15, 2021
@tux-tn @firlus
@dspinellis @kyled7
chore: setup github actions (#1553)
9debd5e 
* chore: prevent git from ignoring src/index.js file

* chore: remove unused exclusion from nyc config

* chore: replace travis-ci with github actions

* chore: fix issue with github workflow config

* chore: fix condition for coverage generation and sending

* chore: treat node version as int

* docs: replace travis with github actions badge

* chore: add npm publish github action

* chore: remove auto-generated files

* chore: improve github actions styles

* chore: use correct repo url to prevent unecessary redirect

* chore: lint package.json file

* chore: add new line at end of file

* feat(isMobilePhone): update de-CH, add fr-CH, it-CH locales (#1554)

* fix(isMobilePhone): update de-CH locale (#1549)
feat(isMobilePhone): add fr-CH locale (#1549)
feat(isMobilePhone): add it-CH locale (#1549)

* fix(isMobilePhone): update de-CH, fr-CH and it-CH locale in validator.min.js(#1549)

* fix(isMobilePhone): update fr-CH and it-CH locale aliases (#1549)

Co-authored-by: Ashutosh Kumar <kumar.ashutosh@siemens.com>

* feat(isLicensePlate): new validator 🎉 (#1495)

* Added isLicensePlate check with german locale

* de-LI (Liechtenstein) validator

* Added albanian number plates

* reversed changes in index.js

* reversed changes in index.js

* Refactored de-DE into one big regex, expanded tests fot de-DE

* added pt-PT locale

* Fixed coverage problem

* feat(isLicensePlate): clean build

* coverage is now 100%

* Update README.md

* Update README.md

* fix(isTaxID): fix el-GR locale when checksum is 10 (#1529)

Add correct tax identifier to demonstrate issue and fix.

Thanks to: Panos Papadopoulos

* feat(isMobileNumber): add support new telco numbers for VN locale (#1575)

* Support new VN mobile phone 087 (https://didong.itelecom.vn/)

* Add test for new telco number

Co-authored-by: Kyle Dinh <kyle@Kyles-Mac-mini.telio>

* chore: set a fixed ubuntu version instead of relying on latest

Co-authored-by: Ashutosh Kumar <dinfekted@users.noreply.github.com>
Co-authored-by: Ashutosh Kumar <kumar.ashutosh@siemens.com>
Co-authored-by: Michael Firlus <michael@4lus.de>
Co-authored-by: Diomidis Spinellis <dds@aueb.gr>
Co-authored-by: Kyle Dinh <kyled7@users.noreply.github.com>
Co-authored-by: Kyle Dinh <kyle@Kyles-Mac-mini.telio>
@profnandaa profnandaa mentioned this issue Feb 15, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug good first issue help needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(isMobilePhone): update de-CH locale (#1549)
2 participants
@profnandaa @seyfer