feat: added reconciliation frequency annotation #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- annotation for defining reconciliation frequency can now be added specified. - providing the annotation is optional - example added to `config/samples/` Signed-off-by: Adnan Gulegulzar <gulegulzaradnan@gmail.com>
Signed-off-by: Adnan Gulegulzar <gulegulzaradnan@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #327 +/- ##
==========================================
+ Coverage 58.09% 58.22% +0.13%
==========================================
Files 8 8
Lines 630 632 +2
==========================================
+ Hits 366 368 +2
Misses 234 234
Partials 30 30
Continue to review full report in Codecov by Sentry.
|
arturshadnik
pushed a commit
that referenced
this pull request
Dec 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.4](v0.3.3...v0.3.4) (2024-12-10) ### Features * added reconciliation frequency annotation ([#327](#327)) ([ba2bc7c](ba2bc7c)) ### Other * make reviewable ([#303](#303)) ([7d64638](7d64638)) * make reviewable ([#307](#307)) ([23889ab](23889ab)) * make reviewable ([#308](#308)) ([fb0bdc8](fb0bdc8)) * re-scaffold project ([#334](#334)) ([9f2660b](9f2660b)) * update build gsm ([977f75c](977f75c)) * update renovate.json ([afecc4e](afecc4e)) * Update renovate.json ([607c5d8](607c5d8)) ### Dependency Updates * **deps:** update all non-major dependencies ([#312](#312)) ([9701333](9701333)) * **deps:** update build digest to 3463b98 ([#315](#315)) ([9d34e83](9d34e83)) * **deps:** update build digest to 3840c9d ([#318](#318)) ([a34faaf](a34faaf)) * **deps:** update build digest to 5ffe724 ([#319](#319)) ([3c2a763](3c2a763)) * **deps:** update build digest to a46a554 ([#322](#322)) ([afbc85d](afbc85d)) * **deps:** update build digest to db64f63 ([#314](#314)) ([86ebfc0](86ebfc0)) * **deps:** update build digest to dd09b58 ([#321](#321)) ([b987563](b987563)) * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to 4b041aa ([#316](#316)) ([96e5133](96e5133)) * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to 7ab30f8 ([#317](#317)) ([69164a5](69164a5)) * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to 92ffab8 ([#320](#320)) ([423dc64](423dc64)) * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to b9e7404 ([#328](#328)) ([e5fdeb1](e5fdeb1)) * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to c3c6ff6 ([#304](#304)) ([c62dabe](c62dabe)) * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to cb9aea3 ([#313](#313)) ([8886395](8886395)) * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to e21b7a4 ([#293](#293)) ([de70e53](de70e53)) * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to e718692 ([#300](#300)) ([aea4e84](aea4e84)) * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to fb97845 ([#309](#309)) ([ba51baf](ba51baf)) * **deps:** update kubernetes packages to v0.31.1 ([#296](#296)) ([2d5d1df](2d5d1df)) * **deps:** update kubernetes packages to v0.31.2 ([#305](#305)) ([fcc770c](fcc770c)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.21.0 ([#310](#310)) ([ceca186](ceca186)) * **deps:** update module github.com/onsi/gomega to v1.35.0 ([#311](#311)) ([2614708](2614708)) * **deps:** update module github.com/onsi/gomega to v1.36.0 ([#325](#325)) ([976b60a](976b60a)) * **deps:** update module github.com/stretchr/testify to v1.10.0 ([#324](#324)) ([e8a10cd](e8a10cd)) * **deps:** update module github.com/validator-labs/validator to v0.1.10 ([#290](#290)) ([9188bac](9188bac)) * **deps:** update module github.com/validator-labs/validator to v0.1.11 ([#294](#294)) ([5e23703](5e23703)) * **deps:** update module github.com/validator-labs/validator to v0.1.12 ([#299](#299)) ([cb78a3d](cb78a3d)) * **deps:** update module github.com/validator-labs/validator to v0.1.13 ([#323](#323)) ([c19fcfd](c19fcfd)) * **deps:** update module github.com/validator-labs/validator to v0.1.14 ([#329](#329)) ([6eb352c](6eb352c)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.2 ([#292](#292)) ([7564460](7564460)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.3 ([#295](#295)) ([58f06d8](58f06d8)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.4 ([#301](#301)) ([b2dfe52](b2dfe52)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.19.1 ([#306](#306)) ([1aaf840](1aaf840)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Integrates annotation helper function from validator-labs/validator#358
Description
config/samples/Notes
I tested the changes with a kind cluster. I had to remove
- "--metrics-bind-address=127.0.0.1:8080"from the manager's arguments inconfig/default/manager_auth_proxy_patch.yaml. However, I reverted the change for this PR.