Skip to content

Commit

Permalink
Fix skbuild using too new metadata version
Browse files Browse the repository at this point in the history
scikit-build-core set the metadata version to 2.2 that is not yet supported by PyPI.

This was due to a dynamic pyproject.toml section being used.
pypi/warehouse#9660
  • Loading branch information
valgur committed Feb 26, 2024
1 parent dfe0692 commit a88ff32
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
5 changes: 2 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,8 @@ if(MSVC)
endif()

## Python bindings

set(BUILD_PYTHON FALSE CACHE BOOL "Build a Python module in addition to the library")
if(BUILD_PYTHON)
option(BUILD_PYTHON "Build velodyne_decoder_pylib Python module" FALSE)
if(BUILD_PYTHON OR SKBUILD)
find_package(Python REQUIRED COMPONENTS Interpreter Development.Module)
find_package(pybind11 CONFIG REQUIRED)

Expand Down
7 changes: 1 addition & 6 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ keywords = [
license = {text = "BSD-3-Clause"}
classifiers = [
"License :: OSI Approved :: BSD License",
"Programming Language :: Python :: 2",
"Programming Language :: Python :: 3",
"Operating System :: OS Independent",
]
Expand All @@ -26,10 +25,6 @@ dependencies = [
"dpkt",
"pyyaml",
]
dynamic = ["optional-dependencies"]

[tool.setuptools.dynamic]
optional-dependencies.tests = { file = ["requirements-dev.txt"] }

[project.scripts]
extract-hdl64e-calibration = "velodyne_decoder.hdl64e:cli"
Expand Down Expand Up @@ -63,7 +58,7 @@ BUILD_SHARED_LIBS = false
build = "*"
# Disable building of PyPy wheels on all platforms
skip = "pp*"
before-test = "pip install -r {project}/requirements-dev.txt --extra-index-url https://rospypi.github.io/simple/ --upgrade --upgrade-strategy eager"
before-test = "pip install -r {project}/requirements-dev.txt"
test-command = "pytest {project}/test --color=yes -v"
build-verbosity = 1
archs = "auto64"
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# --extra-index-url https://rospypi.github.io/simple/
--extra-index-url https://rospypi.github.io/simple/
pytest
requests
rosbag
Expand Down

0 comments on commit a88ff32

Please sign in to comment.