-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dpi and savepdf options to comparison report for publications #123
Conversation
I'm definitely getting my money's worth out of @valeriupredoi this week! Thanks for the hard work mate! |
only that you're not paying me a single penny though 🤣 Lemme have a looksee in a jiffy 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine by me, but I'd add a default value for dpi
, and I'd also add a check on how dpi
is specified by the user - if it's not like eg dpi=200
and it's dpi=200x300
that should probably be caught before Matplotlib throws a hissy (basically try: int(dpi) else: raise ValueError("that need be an int you dummy"
)) - up to you
If we leave the dpi as the default value (
|
okidoki 👍 |
Added a int flag check for dpi. |
Done here. Going to merge if V is happy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff! Fire at will, bud 🍺
Colin asked for a higher resolution version of the images, so I added an option is the report maker to set image resolution in dpi, and also a flag to save images as a pdf.