✨ improved progress support #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maartenbreddels
commented
Nov 24, 2021
- progress is now an argument to vaex.open to be used in combination with convert
- more titles for progress values
- rich progress support
| - name: Test comand line | ||
| run: | | ||
| vaex convert ~/.vaex/data/helmi-dezeeuw-2000-FeH-v2-10percent.hdf5 test.parquet | ||
| pip install rich |
There was a problem hiding this comment.
Should this be added as a proper dependency now? So we can track in case something changes with versions etc.?
There was a problem hiding this comment.
Not for now, the import is also done non-top level, if it mature, and if we are going to use rich at more places, I'm happy to make it a dependency.
4364d10 to
bfa45ea
Compare
|
screencaps
|
a59c3ad to
1513141
Compare
* progress is now an argument to vaex.open to be used in combination with convert * more titles for progress values * rich progress support
1513141 to
f353b91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.