[memory_checker] Change log severity to WARNING in a case when the docker service is not running. #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To fix the logic introduced by [memory_checker] Do not check memory usage of containers which are not created #11129.
There could be a scenario before the reboot, where
docker service
has stoppedroot@sonic:/home/admin# monit status container_memory_telemetry
In such scenario, the
memory_checker
script will throw an error to the syslog:But, actually, this scenario is a correct behavior, because when the docker service is stopped, the Unix socket is destroyed and that is why we could see the
FileNotFoundError(2, 'No such file or directory'
exception in the syslog.Work item tracking
How I did it
Change the log severity to the warning and changed the return value.
How to verify it
It is really hard to catch the exact moment described in the
Why I did it
section.In order to check the logic:
root@sonic:/home/admin# monit restart container_memory_telemetry
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)