WIP: gossipsub: add optional per-peer delay metrics #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
|
The current version is one that exposes lots of data: one histogram per peer. Thus, the metric is kept optional. Later we might streamline this to collect only stats like mean and maybe stddev. I'm also wondering whether we should add this here, or move it to scoring.nim. It would also be nice to collect some delay related data on first arrivals, for example delay between the first and the second arrival. |
|
Just a note, we won't be able to enable per-peer metric on the fleet (too expensive) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add more delay related metrics to evaluate GossipSub improvement proposals.
See libp2p/specs#413 for related discussions