-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove .po files from distribution bundles #2243
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2243 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 196 196
Lines 11891 11891
Branches 1717 1717
=========================================
Hits 11891 11891 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's trim some extras 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔧
Now that `.po` files are no longer included in distribution bundles (vacanza#2243), having this test look at `.po` files makes things slightly more difficult for downstream distributors such as Debian, since we run the tests on the equivalent of the built wheel.
Proposed change
Remove .po files from distribution bundles (sdist and bdist).
Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green