Added Sri Lanka holidays #2228
Open
Added Sri Lanka holidays #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2228 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 196 197 +1
Lines 11849 11927 +78
Branches 1710 1719 +9
=========================================
+ Hits 11849 11927 +78 ☔ View full report in Codecov by Sentry. |
arkid15r
reviewed
Jan 15, 2025
This reverts commit 8b59449.
PPsyrius
requested changes
Jan 15, 2025
Comment on lines
+12
to
+15
| # SOME DESCRIPTIVE TITLE | ||
| # This file is distributed under the same license as the Holidays package. | ||
| # Prateekshit Jaiswal <prateekshitjaiswal73@gmail.com>, 2025. | ||
| #, fuzzy |
There was a problem hiding this comment.
Suggested change
| # SOME DESCRIPTIVE TITLE | |
| # This file is distributed under the same license as the Holidays package. | |
| # Prateekshit Jaiswal <prateekshitjaiswal73@gmail.com>, 2025. | |
| #, fuzzy | |
| # | |
| # Sri Lanka holidays en_US localization. | |
| # |
Please use the standardized header format here
Comment on lines
+12
to
+15
| # SOME DESCRIPTIVE TITLE | ||
| # This file is distributed under the same license as the Holidays package. | ||
| # Prateekshit Jaiswal <prateekshitjaiswal73@gmail.com>, 2025. | ||
| #, fuzzy |
There was a problem hiding this comment.
Suggested change
| # SOME DESCRIPTIVE TITLE | |
| # This file is distributed under the same license as the Holidays package. | |
| # Prateekshit Jaiswal <prateekshitjaiswal73@gmail.com>, 2025. | |
| #, fuzzy | |
| # | |
| # Sri Lanka holidays ta_LK localization. | |
| # |
Comment on lines
+12
to
+15
| # SOME DESCRIPTIVE TITLE | ||
| # This file is distributed under the same license as the Holidays package. | ||
| # Prateekshit Jaiswal <prateekshitjaiswal73@gmail.com>, 2025. | ||
| #, fuzzy |
There was a problem hiding this comment.
Suggested change
| # SOME DESCRIPTIVE TITLE | |
| # This file is distributed under the same license as the Holidays package. | |
| # Prateekshit Jaiswal <prateekshitjaiswal73@gmail.com>, 2025. | |
| #, fuzzy | |
| # | |
| # Sri Lanka holidays. | |
| # |
There was a problem hiding this comment.
After the make check command is executed, the output is as follows:
ruff-format..............................................................Failed
- hook id: ruff-format
- files were modified by this hook
1 file reformatted, 384 files left unchanged
The command restores the changes that were made.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Added Sri Lanka holidays
Closes #1272
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green