-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Singapore holidays: add en_SG
, en_US
, th
localization
#2031
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2031 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 189 189
Lines 11479 11483 +4
Branches 1795 1795
=========================================
+ Hits 11479 11483 +4 ☔ View full report in Codecov by Sentry. |
I completely agree with en_US standardization! (As I understand, these names, "Hari Raya Puasa" and "Hari Raya Haji", are in fact Malay) |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Proposed change
Adds English (
en_SG
,en_US
) and Thai (th
) localization for Singapore holidays.I tried to standardize
en_US
localization to the common Islamic holiday terms used in this library, i.e.Eid al-Fitr
instead ofHari Raya Puasa
used inen_SG
, so any feedback here would be appreciated.Note
Thai Public Broadcasting Service (Thai PBS) is used as the primary source for Islamic holidays naming over Thai Wikipedia ones i.e.
อีฎิ้ลฟิตริ
instead ofอีดิลฟิฏร์
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally