Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guatemala holidays #1364

Merged
merged 46 commits into from
Jul 14, 2023
Merged

Add Guatemala holidays #1364

merged 46 commits into from
Jul 14, 2023

Conversation

aztrock
Copy link
Contributor

@aztrock aztrock commented Jul 7, 2023

Proposed change

Your PR description goes here.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aztrock, thank you for adding new countries to Python Holidays! Please look at suggestions below.

holidays/countries/guatemala.py Outdated Show resolved Hide resolved
holidays/countries/guatemala.py Outdated Show resolved Hide resolved
holidays/countries/guatemala.py Outdated Show resolved Hide resolved
holidays/countries/guatemala.py Outdated Show resolved Hide resolved
holidays/countries/guatemala.py Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/GT.po Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/GT.po Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/SK.po Outdated Show resolved Hide resolved
holidays/locale/es/LC_MESSAGES/GT.po Outdated Show resolved Hide resolved
self._add_holiday(tr("Día de la Independencia"), SEP, 15)

# Revolution Day
self._add_holiday(tr("Dia de la Revolución"), OCT, 20)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decree 19-2018 includes this holiday in movable holidays list too. Has it changed in any way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is correct, but looking in the local newspapers, they say it doesn't change. or it stays at one friday. check.

https://republica.gt/vive-guatemala/feriados-2023-en-guatemala-fines-de-semana-largos-y-asuetos-de-este-ano-en-el-pais-202331414310

October 20 "Revolution Day": October 20 will fall on Friday, the law does not establish that it can be run. However, since it is a day before a weekend, Guatemalans will have a long rest of three days, since those who do not work or study on weekends will have the opportunity to rest on Friday, Saturday and Sunday.

https://www.prensalibre.com/guatemala/comunitario/asuetos-en-guatemala-2023-cuantos-asuetos-y-feriados-largos-quedan-en-lo-que-resta-del-ano/

Revolution Day: October 20 is also non-transferable, but it will be Friday, so it would have another long weekend.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, please this have a chenge from CC in EXPEDIENTE 5536-2018 i check all document.

this is for 1 may and 20 oct.

https://leyes.infile.com/index.php?id=181&id_publicacion=81055&cmd=login

for 15 set i looking for more info.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for 1 may and 20 oct.

Yes, I see. So May 1 and Oct 20 movability is canceled from 2020, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for 15 set i looking for more info.

I said nothing about Sep 15. It's ordinary holiday, as far as I can see.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for 1 may and 20 oct.

Yes, I see. So May 1 and Oct 20 movability is canceled from 2020, right?

yes

for 15 set i looking for more info.

I said nothing about Sep 15. It's ordinary holiday, as far as I can see.

I am confirming this date and looking to see if there is another decree or file, because they did not move it to Monday according to the decree.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In summary, I see it as follows:
May 1 - move in 2019 only,
Jun 30 - move since 2019,
Oct 20 - move in 2018-2019 only.
Am I right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consideration:

  • law 19-2018 18 oct 2018
  • EXPEDIENTE 5536-2018 (CC) 17 abr 2020

May 1:

  • 2018 <= 1 May
  • 2019 = Move to Monday: law 19 2018
  • 2020 >= 1 May

Jun 30:

  • 2019 >= Move since 2019 law 19 2018

Oct 20:

  • 2018-2019 = Only move this years

yes you right.

aztrock and others added 6 commits July 7, 2023 13:35
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
@KJhellico KJhellico changed the base branch from master to beta July 8, 2023 17:20
@KJhellico KJhellico changed the title add guatemala holidays. Add Guatemala holidays Jul 8, 2023
@coveralls
Copy link

coveralls commented Jul 10, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 03d87f7 on aztrock:master into ffacf6d on dr-prodigy:beta.

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
holidays/countries/guatemala.py Outdated Show resolved Hide resolved
aztrock and others added 12 commits July 13, 2023 08:48
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final fixes and everything is ready to go :)

holidays/countries/guatemala.py Outdated Show resolved Hide resolved
holidays/countries/guatemala.py Outdated Show resolved Hide resolved
holidays/countries/guatemala.py Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/GT.po Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/GT.po Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/GT.po Outdated Show resolved Hide resolved
holidays/locale/es/LC_MESSAGES/GT.po Outdated Show resolved Hide resolved
holidays/locale/es/LC_MESSAGES/GT.po Outdated Show resolved Hide resolved
tests/countries/test_guatemala.py Outdated Show resolved Hide resolved
tests/countries/test_guatemala.py Outdated Show resolved Hide resolved
aztrock and others added 10 commits July 14, 2023 07:38
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇬🇹 LGTM

@arkid15r arkid15r merged commit 651173a into vacanza:beta Jul 14, 2023
@arkid15r
Copy link
Collaborator

Merged into beta.

Thank you so much for adding Guatemala holidays @aztrock!

This was referenced Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants