-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Guatemala holidays #1364
Add Guatemala holidays #1364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aztrock, thank you for adding new countries to Python Holidays! Please look at suggestions below.
holidays/countries/guatemala.py
Outdated
self._add_holiday(tr("Día de la Independencia"), SEP, 15) | ||
|
||
# Revolution Day | ||
self._add_holiday(tr("Dia de la Revolución"), OCT, 20) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decree 19-2018 includes this holiday in movable holidays list too. Has it changed in any way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is correct, but looking in the local newspapers, they say it doesn't change. or it stays at one friday. check.
October 20 "Revolution Day": October 20 will fall on Friday, the law does not establish that it can be run. However, since it is a day before a weekend, Guatemalans will have a long rest of three days, since those who do not work or study on weekends will have the opportunity to rest on Friday, Saturday and Sunday.
Revolution Day: October 20 is also non-transferable, but it will be Friday, so it would have another long weekend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, please this have a chenge from CC in EXPEDIENTE 5536-2018 i check all document.
this is for 1 may and 20 oct.
https://leyes.infile.com/index.php?id=181&id_publicacion=81055&cmd=login
for 15 set i looking for more info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for 1 may and 20 oct.
Yes, I see. So May 1 and Oct 20 movability is canceled from 2020, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for 15 set i looking for more info.
I said nothing about Sep 15. It's ordinary holiday, as far as I can see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for 1 may and 20 oct.
Yes, I see. So May 1 and Oct 20 movability is canceled from 2020, right?
yes
for 15 set i looking for more info.
I said nothing about Sep 15. It's ordinary holiday, as far as I can see.
I am confirming this date and looking to see if there is another decree or file, because they did not move it to Monday according to the decree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In summary, I see it as follows:
May 1 - move in 2019 only,
Jun 30 - move since 2019,
Oct 20 - move in 2018-2019 only.
Am I right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consideration:
- law 19-2018 18 oct 2018
- EXPEDIENTE 5536-2018 (CC) 17 abr 2020
May 1:
- 2018 <= 1 May
- 2019 = Move to Monday: law 19 2018
- 2020 >= 1 May
Jun 30:
- 2019 >= Move since 2019 law 19 2018
Oct 20:
- 2018-2019 = Only move this years
yes you right.
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
May 1: 2018 <= 1 May 2019 = Move to Monday: law 19 2018 2020 >= 1 May
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final fixes and everything is ready to go :)
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇬🇹 LGTM
Merged into beta. Thank you so much for adding Guatemala holidays @aztrock! |
Proposed change
Your PR description goes here.
Type of change
Checklist
beta
branch of the repositorymake pre-commit
make test
,make tox
(we strongly encourage adding tests to your code)