Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add estimated_label localization support to Asian holiday groups #1229

Merged
merged 2 commits into from
May 26, 2023

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Add estimated_label localization support to Asian holiday groups (Buddhist, Chinese, Hindu).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency upgrade (version update)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@KJhellico KJhellico requested a review from arkid15r May 24, 2023 10:27
@KJhellico
Copy link
Collaborator Author

@PPsyrius, now ChineseCalendarHolidays() should support estimated_label localization too (will be useful for #1168, as Brunei have Lunar New Year holiday).

@coveralls
Copy link

coveralls commented May 24, 2023

Coverage Status

Coverage: 99.926% (-3.0e-05%) from 99.926% when pulling 1f4eb37 on KJhellico:add-asian-estimated-translation into 6b95982 on dr-prodigy:beta.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

holidays/holiday_groups.py Outdated Show resolved Hide resolved
holidays/holiday_groups.py Outdated Show resolved Hide resolved
holidays/holiday_groups.py Outdated Show resolved Hide resolved
@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label May 25, 2023
Co-authored-by: Arkadii Yakovets <ark@cho.red>
@arkid15r arkid15r merged commit 89897e1 into vacanza:beta May 26, 2023
@arkid15r arkid15r removed the ready for beta Ready to merge on beta branch label May 26, 2023
@KJhellico KJhellico deleted the add-asian-estimated-translation branch May 27, 2023 11:37
@KJhellico KJhellico mentioned this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants