Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n related workflows #1140

Merged
merged 11 commits into from
May 26, 2023
Merged

Update l10n related workflows #1140

merged 11 commits into from
May 26, 2023

Conversation

arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented May 4, 2023

Proposed change

Multiple improvements related to PH l10n:

  • Add PoC Arabic l10n for CA, ET, UA
  • Add minor fixes and updates
  • Update existing l10n tests to use TestCase::assertLocalizedHolidays
  • Change check make target to include make l10n
  • Fix .po file generation warning for AR, CO, CR, RS
  • Bulk update stale .po files (location)
  • Remove unused l10n test methods from common::TestCase

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency upgrade (version update)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

  - Update existing l10n tests to use TestCase::assertLocalizedHolidays
  - Change `check` make target to include `make l10n`
  - Fix .po file generation warning for AR, CO, CR, RS
  - Bulk update stale .po files (location)
  - Remove unused l10n test methods from common::TestCase
@arkid15r arkid15r requested a review from KJhellico May 4, 2023 03:00
Copy link
Collaborator Author

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR look massive, however the majority of changed .po files are bulk updates (gettext string locations). A review is required for Argentina, Colombia, Costa Rica, and Serbia l10n files.

Thank you!

@coveralls
Copy link

coveralls commented May 4, 2023

Coverage Status

Coverage: 99.926% (-3.0e-05%) from 99.926% when pulling 0157966 on arkid15r:update-l10n into 6b95982 on dr-prodigy:beta.

@arkid15r arkid15r requested a review from KJhellico May 23, 2023 16:46
@arkid15r
Copy link
Collaborator Author

@PPsyrius, @abh31000 just a quick heads-up on this.
I added flexible estimated_label support so #1168 should be unblocked after the merge (or now if merged locally).

@abh31000 the estimated_label should support Arabic language too. I've made an attempt to localize some countries and request your review for holidays/locale/ar/LC_MESSAGES/(CA,ET,UK).po files. Thank you!

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
holidays/locale/ar/LC_MESSAGES/UA.po Outdated Show resolved Hide resolved
holidays/locale/ar/LC_MESSAGES/ET.po Outdated Show resolved Hide resolved
holidays/locale/ar/LC_MESSAGES/ET.po Outdated Show resolved Hide resolved
holidays/locale/ar/LC_MESSAGES/ET.po Outdated Show resolved Hide resolved
holidays/locale/ar/LC_MESSAGES/UA.po Show resolved Hide resolved
tests/countries/test_ethiopia.py Outdated Show resolved Hide resolved
tests/countries/test_ethiopia.py Outdated Show resolved Hide resolved
tests/countries/test_ethiopia.py Outdated Show resolved Hide resolved
tests/countries/test_ukraine.py Outdated Show resolved Hide resolved
tests/countries/test_ukraine.py Outdated Show resolved Hide resolved
Co-authored-by: abh31000 <abdelkhalekbouklihacene67@gmail.com>
holidays/locale/ar/LC_MESSAGES/UA.po Outdated Show resolved Hide resolved
tests/countries/test_ukraine.py Outdated Show resolved Hide resolved
tests/countries/test_ukraine.py Outdated Show resolved Hide resolved
tests/countries/test_ukraine.py Outdated Show resolved Hide resolved
tests/countries/test_ukraine.py Outdated Show resolved Hide resolved
arkid15r and others added 2 commits May 23, 2023 19:29
Co-authored-by: abh31000 <abdelkhalekbouklihacene67@gmail.com>
@arkid15r arkid15r requested a review from KJhellico May 24, 2023 16:19
PPsyrius added a commit to PPsyrius/python-holidays that referenced this pull request May 25, 2023
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label May 25, 2023
@arkid15r arkid15r merged commit bee68d7 into vacanza:beta May 26, 2023
@arkid15r arkid15r deleted the update-l10n branch May 26, 2023 15:10
@arkid15r arkid15r removed the ready for beta Ready to merge on beta branch label May 26, 2023
@KJhellico KJhellico mentioned this pull request Jun 5, 2023
PPsyrius added a commit to PPsyrius/python-holidays that referenced this pull request Jun 7, 2023
* Brunei holidays

* Implementing Fix Suggestions Part 1

Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>

* Add missing `countries/__init__.py`

Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>

* misc. fixes

* Update no. of supported countries to 123

* increments country count

* Update formatting

* [BN] Adapting code for vacanza#1140's changes

* [BN] switch from `tr("...")` to `self.tr("...")`

* [BN] forgot to run tox

* oof

* [BN] hopefully last fixes needed

* [BN] Rearrange holidays to prevent Islamic observed duplications

Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>

* [BN] Implementing suggestions Part 2

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>

* [BN] Implementing suggestions Part 3

Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>

* [BN] reformat for pre-commit's `black` compliance

* [BN] fix mismatch README.rst indentation

* [BN] migrate to new CustomCalendar implementation

* [BN] fix mismatch README.rst indentation again

* [BN] fix *estimate tag not appearing for Eid al-fitr, reorder locs

* [BN] Suggestions implemented June 6th

Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>

* [BN] incrrement PH patch number to 0.27

---------

Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants