-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update l10n related workflows #1140
Conversation
- Update existing l10n tests to use TestCase::assertLocalizedHolidays - Change `check` make target to include `make l10n` - Fix .po file generation warning for AR, CO, CR, RS - Bulk update stale .po files (location) - Remove unused l10n test methods from common::TestCase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR look massive, however the majority of changed .po files are bulk updates (gettext string locations). A review is required for Argentina, Colombia, Costa Rica, and Serbia l10n files.
Thank you!
Add PoC Arabic l10n for CA, ET, UA Add minor fixes and updates
@PPsyrius, @abh31000 just a quick heads-up on this. @abh31000 the |
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: abh31000 <abdelkhalekbouklihacene67@gmail.com>
Co-authored-by: abh31000 <abdelkhalekbouklihacene67@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
* Brunei holidays * Implementing Fix Suggestions Part 1 Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * Add missing `countries/__init__.py` Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> * misc. fixes * Update no. of supported countries to 123 * increments country count * Update formatting * [BN] Adapting code for vacanza#1140's changes * [BN] switch from `tr("...")` to `self.tr("...")` * [BN] forgot to run tox * oof * [BN] hopefully last fixes needed * [BN] Rearrange holidays to prevent Islamic observed duplications Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * [BN] Implementing suggestions Part 2 Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * [BN] Implementing suggestions Part 3 Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> * [BN] reformat for pre-commit's `black` compliance * [BN] fix mismatch README.rst indentation * [BN] migrate to new CustomCalendar implementation * [BN] fix mismatch README.rst indentation again * [BN] fix *estimate tag not appearing for Eid al-fitr, reorder locs * [BN] Suggestions implemented June 6th Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> * [BN] incrrement PH patch number to 0.27 --------- Co-authored-by: Arkadii Yakovets <ark@cho.red> Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
Proposed change
Multiple improvements related to PH l10n:
check
make target to includemake l10n
Type of change
Checklist
beta
branch of the repositorymake pre-commit
make test
,make tox
(we strongly encourage adding tests to your code)