Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make disabled menu bar buttons focusable with feature flag #8518

Open
wants to merge 12 commits into
base: feat/focusable-disable-components
Choose a base branch
from
Open

feat: make disabled menu bar buttons focusable with feature flag #8518

wants to merge 12 commits into from

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jan 16, 2025 •
edited
Loading

Description

To improve accessibility, the PR introduces an option to make disabled menu bar buttons focusable so that screen readers can reach and announce them to users, including their tooltips. This behavior is currently experimental and can be enabled with the feature flag:

// Set before any menu bar is added to the DOM.
window.Vaadin.featureFlags.accessibleDisabledButtons = true;

Note

I recommend enabling "Hide whitespaces" to hide irrelevant changes from the diff.

Depends on

Part of #4585

Type of change

  • Feature

@vursen vursen force-pushed the feat/focusable-disable-components branch from 911d0b4 to 35f06ee Compare January 16, 2025 09:12
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch 5 times, most recently from 699c5e5 to 3f14b15 Compare January 17, 2025 10:59
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from 3f14b15 to 93efcd6 Compare January 17, 2025 11:05
@vursen vursen marked this pull request as ready for review January 17, 2025 11:05
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from 93efcd6 to 0fcd8b1 Compare January 17, 2025 11:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan Awaiting requested review from web-padawan

@sissbruecker sissbruecker Awaiting requested review from sissbruecker

@tomivirkki tomivirkki Awaiting requested review from tomivirkki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vursen