Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset _hasInputValue on programmatic input change (CP:14) #831

Merged
merged 9 commits into from
May 4, 2023

Conversation

mukherjeesudebi
Copy link
Contributor

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

test/events.html Outdated Show resolved Hide resolved
@vursen
Copy link
Contributor

vursen commented May 3, 2023

Would it make sense to include vaadin/web-components#5645 directly in this PR?

test/events.html Outdated Show resolved Hide resolved
test/events.html Outdated Show resolved Hide resolved
test/events.html Outdated Show resolved Hide resolved
test/events.html Outdated Show resolved Hide resolved
@vursen
Copy link
Contributor

vursen commented May 3, 2023

One test is failing on iOS Simulator and I can't understand why:

iOS Simulator iphone 10.3 ✖ test/events.html » events » has-input-value-changed event » without value » with user input » should be fired when clearing the user input with Esc

  expected false to be true
    <unknown> at   AssertionError at /components/chai/chai.js:5260:0
    <unknown> at           assert at /components/chai/chai.js:259:0
    <unknown> at        <unknown> at /components/chai/chai.js:597:0
    <unknown> at      addProperty at /components/chai/chai.js:3951:0
    <unknown> at        <unknown> at events.html:110:0

test/events.html Outdated Show resolved Hide resolved
test/events.html Outdated Show resolved Hide resolved
@vursen vursen merged commit aa3f497 into master May 4, 2023
@vursen vursen deleted the backport-reset-hasInputValue branch May 4, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants