Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Custom Validator demo #569

Closed
wants to merge 1 commit into from
Closed

Fix Custom Validator demo #569

wants to merge 1 commit into from

Conversation

samiheikki
Copy link
Contributor

@samiheikki samiheikki commented Jun 10, 2018 •
edited by manolo
Loading

If you navigate Basic demos -> Advanced -> Basic -> Advanced you get the following error to your console:
screen shot 2018-06-10 at 12 02 21

vaadin-date-picker-current-year custom element is being registered again and this breaks the custom validator demo as well.

This change is Reviewable

limonte
limonte approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@limonte limonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's a conflict.

I will close this PR in favor of #590

@limonte limonte closed this Jul 25, 2018
@limonte limonte mentioned this pull request Jul 25, 2018
Merged
@limonte limonte deleted the fix/demo-custom-element-registry branch July 25, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonte limonte limonte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samiheikki @limonte