Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change event #558

Merged
merged 1 commit into from
May 30, 2018
Merged

Add change event #558

merged 1 commit into from
May 30, 2018

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented May 29, 2018

Fixes #207


This change is Reviewable

@limonte
Copy link
Contributor

limonte commented May 30, 2018

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@manolo
Copy link
Member

manolo commented May 30, 2018

Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


src/vaadin-date-picker-mixin.html, line 795 at r1 (raw file):

    /**
    * Fired when the user commits a value change.

nit jsdoc lines needs a extra space except first line


Comments from Reviewable

@manolo
Copy link
Member

manolo commented May 30, 2018

:lgtm: apart from formatting nit. Not blocker though


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@tomivirkki
Copy link
Member Author

src/vaadin-date-picker-mixin.html, line 795 at r1 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

nit jsdoc lines needs a extra space except first line

Done.


Comments from Reviewable

@manolo
Copy link
Member

manolo commented May 30, 2018

Review status: 3 of 4 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

1 similar comment
@manolo
Copy link
Member

manolo commented May 30, 2018

Review status: 3 of 4 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@manolo
Copy link
Member

manolo commented May 30, 2018

Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@manolo manolo merged commit 6d3423a into master May 30, 2018
@manolo manolo deleted the change-event branch May 30, 2018 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants