fix: Ensure necessary scripts are loaded into page #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Liferay "Content Page" edit mode, Vaadin portlets are not directly
added to the main page, but loaded into an iframe requesting the same
page in preview mode, and then added to the main page through javascript,
but they are detached from iframe before initialization is completed.
This way, scripts needed to register the portlet web component are not
added to the main document, so the webcomponent is not correctly rendered.
This patch add an additional script to BootstrapHandler response that
takes care to add needed script to main page and to postpone element
registration until they are loaded.
Fixes #202
Type of change
Checklist
Additional for
Feature
type of change