Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): add support for File type in requests #3189

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cromoteca
Copy link
Contributor

Switches to multipart requests if a File object is found anywhere in the body object.

Closes #3132

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.91%. Comparing base (c2d0e1c) to head (deb3777).

Files with missing lines Patch % Lines
packages/ts/frontend/src/Connect.ts 92.30% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3189      +/-   ##
==========================================
+ Coverage   92.89%   92.91%   +0.02%     
==========================================
  Files          85       85              
  Lines        3334     3359      +25     
  Branches      801      807       +6     
==========================================
+ Hits         3097     3121      +24     
  Misses        184      184              
- Partials       53       54       +1     
Flag Coverage Δ
unittests 92.91% <92.30%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
40.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client support for file upload with Hilla endpoints
1 participant