Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vaadin-core to the starter #3682

Closed
wants to merge 2 commits into from

Conversation

mstahv
Copy link
Member

@mstahv mstahv commented Mar 9, 2018

Most people will need the basic components, so it should be included in the
starter.


This change is Reviewable

Most people will need the basic components, so it should be included in the
starter.
@CLAassistant
Copy link

CLAassistant commented Mar 9, 2018

CLA assistant check
All committers have signed the CLA.

@pleku
Copy link

pleku commented Mar 10, 2018

Thanks! I think you also need to change this:
https://github.com/mstahv/flow/blob/6cdcab0ca2ecffc40f45682997bb0c05d8b77462/flow-spring-boot-starter/src/main/resources/META-INF/spring.provides#L1
I have no idea what that means, but now we are providing a whole lot more than just flow and html components.

@mstahv
Copy link
Member Author

mstahv commented Mar 12, 2018

I think we are already providing more at this point. As all our components are now in separate packages, the list would actually be huge for us.

If I understood properly based on my googling (spring-projects/spring-boot#1926) it helps with some suggestions with STS (Spring IDE). The feature is not very well documented so, I'm not sure how important that really is. Any insights @snicoll ?

@snicoll
Copy link
Contributor

snicoll commented Mar 12, 2018

Yeah, I agree it's not very well documented. I've created spring-projects/spring-boot#12435

I wouldn't provide a huge list. One or two items should be enough.

@pleku
Copy link

pleku commented Mar 13, 2018

Actually, we realized that now the time has come to kick out the Spring-addon for Vaadin Flow outside of Flow's basement. It will go on and live in the woods.

This means that this PR is unnecessary for now, as it introduces circular dependencies instead of fixing the underlying issue - the starter should not depend on Flow or the add-on but on the platform.


Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@pleku
Copy link

pleku commented Mar 13, 2018

Issue for moving spring add-on #3695

@pleku pleku closed this Mar 13, 2018
@caalador caalador added this to the Abandoned milestone Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants