Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sumaform should use terraform 0.8.x newer features #73

Closed
moio opened this issue Feb 13, 2017 · 1 comment
Closed

sumaform should use terraform 0.8.x newer features #73

moio opened this issue Feb 13, 2017 · 1 comment

Comments

@moio
Copy link
Contributor

moio commented Feb 13, 2017

REQUIRES: https://github.com/moio/sumaform/issues/71

In many places throughout the codebase we use 0.7 language hacks to simulate conditionals, which were added in 0.8:

https://github.com/moio/sumaform/blob/master/modules/libvirt/client/main.tf#L17-L18
https://github.com/moio/sumaform/blob/master/modules/libvirt/host/main.tf#L8
https://github.com/moio/sumaform/blob/master/modules/libvirt/host/main.tf#L15
https://github.com/moio/sumaform/blob/master/modules/libvirt/host/main.tf#L49
https://github.com/moio/sumaform/blob/master/modules/libvirt/host/main.tf#L72
https://github.com/moio/sumaform/blob/master/modules/libvirt/minion/main.tf#L17-L18
https://github.com/moio/sumaform/blob/master/modules/libvirt/suse_manager/main.tf#L16
https://github.com/moio/sumaform/blob/master/modules/libvirt/suse_manager/main.tf#L32-L33
https://github.com/moio/sumaform/blob/master/modules/libvirt/suse_manager_proxy/main.tf#L27
https://github.com/moio/sumaform/blob/master/modules/openstack/host/main.tf#L35

All of these should be re-written for clarity.

We also make use of a different language hack to work around an issue with interpolated dictionaries, this should also be removed:

https://github.com/moio/sumaform/blob/master/modules/libvirt/base/main.tf#L44
https://github.com/moio/sumaform/blob/master/modules/libvirt/host/main.tf#L68

Note that the above should be tested thoroughly as the new behaviour was not really reliable in 0.8 betas.

Yet other hacks are used to work around the fact it was not possible to declare dependencies on whole modules (now it is). Those should be removed.

https://github.com/moio/sumaform/blob/master/modules/openstack/host/main.tf#L64

moio added a commit that referenced this issue Feb 23, 2017
Remove hacks by using Terraform 0.8 features (#73)
@moio
Copy link
Contributor Author

moio commented Feb 23, 2017

Thanks @ncounter @mbologna for taking care of this!

@moio moio closed this as completed Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant