Rvalue and constant ranges support for the tbb::parallel_sort algorithm #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kboyarinov
reviewed
Oct 11, 2021
9c5b072 to
bbd7d81
Compare
kboyarinov
reviewed
Oct 27, 2021
added 9 commits
October 27, 2021 18:45
Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
…with scomparator with side effects Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
… size parameter Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
0149884 to
94527b7
Compare
Co-authored-by: kboyarinov <konstantin.boyarinov@intel.com>
kboyarinov
reviewed
Oct 28, 2021
Co-authored-by: kboyarinov <konstantin.boyarinov@intel.com>
Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
kboyarinov
reviewed
Oct 29, 2021
Co-authored-by: kboyarinov <konstantin.boyarinov@intel.com>
kboyarinov
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At that moment, the
tbb::parallel_sortalgorithm allows passing only non-constant lvalue reference to a range. But some ranges (like std::span) may provide access to data independent from the container state.Also, this patch contains a rework of the
parallel_sorttesting.Fixes #500
Type of change
Tests
Documentation
Breaks backward compatibility
Notify the following users
@kboyarinov