deprecate aligned_storage

[blonded04]

Description

Removed deprecated aligned_storage_t from tbb

Fixes #1253

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

• bug fix - change that fixes an issue
• new feature - change that adds functionality
• tests - change in tests
• infrastructure - change in infrastructure and CI
• documentation - documentation update

Tests

• added - required for new features and some bug fixes
• not needed

Documentation

• updated in # - add PR number
• needs to be updated
• not needed

Breaks backward compatibility

• Yes
• No
• Unknown

Notify the following users

List users with @ to send notifications

Other information

[blonded04]

Hello @kboyarinov ! Can you please review it?

[kboyarinov]

@blonded04,

Sorry for taking so long to review this. I am OK with the idea of the change.

But the problem is that for the previous implementation, the second argument for std::aligned_storage was missed and hence the my_value field alignment can change if the change would be applied that results in a breaking change (consider the use-case when the container is passed between the border of the translation units built with different oneTBB versions).
To protect the user from this, we need to update the implementation version for all of the concurrent unordered containers by changing the internal namespace number. Currently it is d1. For this change, we need to update it to d2. Could you please do it as part of this PR to make it possible to merge it?

[kboyarinov]

To be consistent with other containers:

Suggested change

	alignas(value_type) alignas(max_nfs_size) char my_value[sizeof(value_type)];
	union {
	value_type my_value;
	}

May be some usage lines should be changed accordingly as well.

[blonded04]

@blonded04,

Sorry for taking so long to review this. I am OK with the idea of the change.

But the problem is that for the previous implementation, the second argument for std::aligned_storage was missed and hence the my_value field alignment can change if the change would be applied that results in a breaking change (consider the use-case when the container is passed between the border of the translation units built with different oneTBB versions). To protect the user from this, we need to update the implementation version for all of the concurrent unordered containers by changing the internal namespace number. Currently it is d1. For this change, we need to update it to d2. Could you please do it as part of this PR to make it possible to merge it?

Thanks for review. I'll finish this PR on this weekend.

[blonded04]

@blonded04,
Sorry for taking so long to review this. I am OK with the idea of the change.
But the problem is that for the previous implementation, the second argument for std::aligned_storage was missed and hence the my_value field alignment can change if the change would be applied that results in a breaking change (consider the use-case when the container is passed between the border of the translation units built with different oneTBB versions). To protect the user from this, we need to update the implementation version for all of the concurrent unordered containers by changing the internal namespace number. Currently it is d1. For this change, we need to update it to d2. Could you please do it as part of this PR to make it possible to merge it?

Thanks for review. I'll finish this PR on this weekend.

next weekend* sorry

[kboyarinov]

@blonded04, I have finalized your PR to fit with our release schedule.
The PR was merged to master today.
Many thanks for working on this fix.