Fix warning and compilation errors #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslusarczyk
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
LGTM, @Xewar313 thank you for fixing bug that blocks distribute-ranges compilation
|
I've added #1851 which reverts unnecessary refactoring changes. Besides that, it would have been great to have separate PRs for each problem solved, but it is not critical, especially after merging. |
|
@Xewar313, do not hesitate to create a PR with the description of your contribution in https://github.com/oneapi-src/oneDPL/blob/main/CREDITS.txt if you wish it to be mentioned there. It certainly deserves it. |
timmiesmith
pushed a commit
that referenced
this pull request
Sep 18, 2024
mmichel11
pushed a commit
that referenced
this pull request
Sep 25, 2024
timmiesmith
pushed a commit
that referenced
this pull request
Nov 21, 2024
This was referenced Nov 21, 2024
timmiesmith
added a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When oneDPL is compiled without spirv, code in parallel_backend_sycl_radix_sort_one_wg.h causes unused variable error, so removing this variable should help.
Presence of function definitions in header files sometimes causes multiple definitions error, changing them to inline should solve the issue