Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Mage version matches in go.mod and tests #15

Merged
merged 2 commits into from
May 4, 2023
Merged

Ensure Mage version matches in go.mod and tests #15

merged 2 commits into from
May 4, 2023

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented May 4, 2023

Fixes: #14

@cpanato
add job to check dependencies
7452921 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Contributor Author

cpanato commented May 4, 2023

example when the job fail: https://github.com/uwu-tools/magex/actions/runs/4886016238/jobs/8720815479?pr=15

level=error msg="./dependencies.yaml indicates that mage should be at version 1.14.0, but the following files didn't match: ./magefile.go"
level=fatal msg="error during command execution: &fmt.wrapError{msg:\"checking local dependencies: Dependencies are not in sync\", err:(*errors.errorString)(0xc000[5](https://github.com/uwu-tools/magex/actions/runs/4886016238/jobs/8720815479?pr=15#step:4:6)b5350)}"

@cpanato
sync mage version
1ed98bd 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato requested a review from justaugustus May 4, 2023 18:23
justaugustus
justaugustus approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@justaugustus justaugustus changed the title add job to check dependencies Ensure Mage version matches in go.mod and tests May 4, 2023
@justaugustus justaugustus merged commit 8b889e7 into uwu-tools:main May 4, 2023
@cpanato cpanato deleted the GH-14 branch May 4, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mage version should be the same in go.mod and tests
2 participants
@cpanato @justaugustus