-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conda environments #48
Conversation
jomey
commented
Jan 10, 2022
•
edited
Loading
edited
- Add cookiecutter library to the lock files (checks box in splash page for hackweek web template #38)
- Update Python to 3.10
- Run test pipeline for Ubuntu and macOSX
- Extend test runs for any changes to a GH action
- Add checks for build script for successful commands
Run the test pipeline with any change to a GH action yml.
Update the conda environments for Ubuntu and Mac OS latest. This bumps the python version to 3.10 and also adds the `cookiecutter` library. The latter is needed to build the new landing page.
Ensure that the website can be build for both operating systems.
Check the return values for the build commands to raise an error upon failure.
The action currently fails as no token is supplied even with publishing being disabled. GitHub needs a value supplied in order to parse the action.
Now that the test action is run on macOS and Linux, the conda lock file needs to be selected accordingly to create the environment.
aa3fa3b
to
7f29617
Compare
The if condition does not seem to work as expected (yet). Trying to compare the 'raw' value.
7f29617
to
2b00409
Compare
Use a default value instead of requiring a 'dummy' value across usages.
Took a little, but this is ready for review now. The |
Thanks @jomey this is looking great! For the preview workflow to work as expected again, we'll need to make a small change to the following lines: jupyterbook-template/.github/workflows/netlifypreview.yaml Lines 14 to 16 in 200fe3c
To --> - uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }} (I think this maybe changed accidentally in the latest revamp)... |
Per recommendation from Scott, pull the latest from the PR HEAD.
Can we allow the 'merge and commit' strategy for PRs for this repo again? |
Done... I like squash and merge for convenience especially with really long PRs with a bunch of commits for testing, but you're totally right that ideally we'd rebase those to maintain a more concise and logical history... |