-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use due credit to point to the relevant citation #29
Conversation
Thanks @arokem ! It points to something I forgot about for the due.py stub -- PEP8 compliance! shame on me.... will fix up within an hour or so, will send you a PR and will fix up your little PEP8 gotchas. |
Am I doing it right otherwise? Will this somehow automagically pull the citation from that DOI? And then when someone runs a script that uses shablona (with |
On Tue, 19 Apr 2016, Ariel Rokem wrote:
yes that is how it should work but few minor tune ups are needed $> python -m duecredit /usr/bin/nosetests shablona So with this change: -due.cite(Doi("10.1167/13.9.30"))
it looks like (yet to figure out why version) wasn't picked up $> python -m duecredit /usr/bin/nosetests shablona .....Ran 5 tests in 0.024s OK DueCredit Report:
4 packages cited References[1] Van Der Walt, S., Colbert, S.C. & Varoquaux, G., 2011. The NumPy array: a structure for efficient numerical computation. Computing in Science & Engineering, 13(2), pp.22–30. I will make sure it works (got behind time so had to switch to other Yaroslav O. Halchenko |
FWIW -- pushed as a PR against your original branch so whenever you merge it it should appear here (apparently you haven't enabled travis for your own clone so tests were not ran) |
BTW why appveyor doesn't report, I thought you had it enabled? |
Ugh. Appveyor is the worst. I just updated the webhook. Let's see if that does the thing. I will also need to write an explanation in the README... |
ceae111
to
1a252e9
Compare
Still need to do:
|
This is a low-cost way to give credit to the relevant publications. This will only express itself, if the user runs it with duecredit. But when that happens, we'll be ready!
added description (so it lists nicely, otherwise how could we know what it is about?), tags to specify that this is the canonical reference (not just an implementation of what is cited in the url) and 'path' since that one is not deduced automagically removed unused import to please flake8
…lable within submodules at import
I think this is ready to go. Merging. |
This is a low-cost way to give credit to the relevant publications. This will
only express itself, if the user runs it with duecredit. But when that happens,
we'll be ready!
Am I doing this right, @yarikoptic?