Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log missing cur_qbd situation #4367

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

pbugni
Copy link
Collaborator

@pbugni pbugni commented Mar 7, 2024

the following was recently found on elk:

File "/opt/venvs/portal/lib/python3.9/site-packages/portal/models/qb_status.py", line 102, in _sync_timeline
    if cur_index > 0:
TypeError: '>' not supported between instances of 'NoneType' and 'int'

pencil tracing the code, can't think of a logical explanation for the combination of variables that would cause this. modified code to stop raising exceptions, be more robust and log an error if this happens again with more detail.

@pep8speaks
Copy link

pep8speaks commented Mar 7, 2024

Hello @pbugni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 99:80: E501 line too long (81 > 79 characters)

Comment last updated at 2024-03-07 03:26:28 UTC

@pbugni pbugni force-pushed the feature/log-missing-cur_qbd-situ branch from bab87be to 3df3919 Compare March 7, 2024 03:26
@pbugni pbugni requested a review from ivan-c March 7, 2024 03:27
Copy link
Member

@ivan-c ivan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pbugni pbugni merged commit fb24914 into develop Mar 7, 2024
2 checks passed
@pbugni pbugni deleted the feature/log-missing-cur_qbd-situ branch March 7, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants