Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix "Basic CI / cargo check (windows-latest)" #44

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Mar 30, 2024

This PR fixes two issues that break the "Basic CI / cargo check (windows-latest)" check:

  • an "unresolved import uucore::utmpx" error in w
  • a "cannot find function parse_meminfo in this scope" error in free

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 45.42%. Comparing base (2505564) to head (00e7190).

Files Patch % Lines
src/uu/free/src/free.rs 40.00% 3 Missing ⚠️
src/uu/w/src/w.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   44.95%   45.42%   +0.47%     
==========================================
  Files          15       15              
  Lines        1733     1803      +70     
  Branches      230      240      +10     
==========================================
+ Hits          779      819      +40     
- Misses        828      854      +26     
- Partials      126      130       +4     
Flag Coverage Δ
macos_latest 44.28% <0.00%> (?)
ubuntu_latest 45.29% <100.00%> (+0.34%) ⬆️
windows_latest 0.13% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cakebaker cakebaker force-pushed the w_disable_utmpx_on_windows branch from 3bad09f to 9da9fc7 Compare March 30, 2024 15:15
@cakebaker cakebaker marked this pull request as draft March 30, 2024 15:35
@cakebaker cakebaker changed the title w: disable utmpx on Windows ci: fix "Basic CI / cargo check (windows-latest)" Mar 31, 2024
@cakebaker cakebaker marked this pull request as ready for review March 31, 2024 12:14
@cakebaker cakebaker requested a review from sylvestre March 31, 2024 12:32
@sylvestre sylvestre merged commit b27251c into uutils:main Mar 31, 2024
11 of 15 checks passed
@cakebaker cakebaker deleted the w_disable_utmpx_on_windows branch March 31, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants